After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302753 - Gthumb does not support HIG zooming shortcuts
Gthumb does not support HIG zooming shortcuts
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.6.x
Other All
: Normal minor
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 305825 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-05-02 18:38 UTC by Sitsofe Wheeler
Modified: 2005-06-07 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (4.10 KB, patch)
2005-05-30 19:16 UTC, Jaap A. Haitsma
none Details | Review

Description Sitsofe Wheeler 2005-05-02 18:38:18 UTC
The HIG
(http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#id2555160 )
specifies the following shortcuts for "zooming":
"Function	Shortcut	Description
Zoom In	Ctrl-Plus	Zoom in on the document
Zoom Out	Ctrl-Minus	Zoom out of the document
Normal Size	Ctrl-0	Restore to zoom level to normal size (generally 100%)"

but gthumb currently doesn't appear to have any shorcuts for zooming.


Other information:
Comment 1 Olav Vitters 2005-05-02 19:51:30 UTC
The menu doesn't show any event, but gthumb actually accepts +, - and 1 (for
normal size). Still the menu should show this if possible.

Also in fullscreen ctrl-+ works, but not in normal view (only +, not ctrl-+).
Comment 2 Jaap A. Haitsma 2005-05-30 16:55:35 UTC
*** Bug 305825 has been marked as a duplicate of this bug. ***
Comment 3 Jaap A. Haitsma 2005-05-30 19:16:17 UTC
Created attachment 47049 [details] [review]
Patch

Patch changing shortcuts

Zoom In Ctrl++	
Zoom Out Ctrl+-
Zoom 1:1 Ctrl+0

Ctrl+= does also do zoom in, 
Because a "=" and "+" are the same key on the normal keyboard.


Paolo,

I noticed that you also make keyboard shortcuts in function
static gint
key_press_cb (GtkWidget   *widget, 
	      GdkEventKey *event,
	      gpointer	   data)
in the file gth-browser.c

Wouldn't it be a better idea to define accelators in the way I did? (Evince and
eog do it also that way). Furthermore I see that instead of a plain xml file
use string constants in gth-browser-ui.h which represent the xml. I guess it
would also be better to convert a plain xml file like eog and evince. If you
agree I can give you a hand.

Anyway thanks a lot for gthumb,

Jaap
Comment 4 Jaap A. Haitsma 2005-06-06 20:12:57 UTC
Paolo, just in case you missed the previous bugmail. Can you review the patch?

Thanks
Comment 5 Paolo Bacchilega 2005-06-07 18:08:43 UTC
patch applied, thank you.