After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105183 - Plain ctrl++ doesn't work to zoom in
Plain ctrl++ doesn't work to zoom in
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
1.9.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 130555 167634 315890 324416 (view as bug list)
Depends on: 94910
Blocks:
 
 
Reported: 2003-02-04 03:20 UTC by Havoc Pennington
Modified: 2005-12-30 19:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
support keypad +/- to zoom in/out (1.44 KB, patch)
2004-04-07 21:05 UTC, Christian Persch
needs-work Details | Review
Its just a mater of replacing ctrl++ with ctrl+shift++ (1.01 KB, patch)
2005-02-01 08:38 UTC, Sudhakar Naidu.A
rejected Details | Review
modified patch for id=36807 (1.19 KB, patch)
2005-02-02 13:08 UTC, Sudhakar Naidu.A
rejected Details | Review

Description Havoc Pennington 2003-02-04 03:20:20 UTC
See HIG bug http://bugzilla.gnome.org/show_bug.cgi?id=94910
which causes this. gnome-terminal has the same problem.
Comment 1 Christian Neumair 2003-06-08 17:47:36 UTC
It works for me with Ephy 0.7 + mozilla 1.3.1.
The only thing which doesn't work is ctrl+= -> normal size, which even
works in mozilla itself.

regs,
 Chris
Comment 2 Mårten Woxberg 2003-09-15 12:45:21 UTC
Ok.. here's the deal..
Ctrl++ works if you use the +\? key (that i have)
but it doesn't work if + is the key on the numeric keyboard.

Ctrl+- does work if you use the -_ key but not if - is the key
on the numeric keyboard.. this should be fixed IMHO.

Im using 0.9.3 compiled by gentoo
Comment 3 Christian Persch 2004-01-05 11:11:49 UTC
*** Bug 130555 has been marked as a duplicate of this bug. ***
Comment 4 Christian Persch 2004-04-07 21:05:02 UTC
Created attachment 26450 [details] [review]
support keypad +/- to zoom in/out
Comment 5 Vincent Noel 2004-08-09 21:40:11 UTC
ping : can this patch still be applied ?
Comment 6 Christian Persch 2004-08-09 21:55:31 UTC
The patch still does the trick, but iirc marco wanted to have this fixed in gtk+
for all apps (?).
Comment 7 Christian Persch 2004-10-13 10:54:29 UTC
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 8 Sudhakar Naidu.A 2005-02-01 08:38:04 UTC
Created attachment 36807 [details] [review]
Its just a mater of replacing ctrl++ with ctrl+shift++

It is confusing to use ctrl++ so it is better to use shift+ctrl++ as shortcut
key
Comment 9 Christian Persch 2005-02-01 14:53:08 UTC
Comment on attachment 36807 [details] [review]
Its just a mater of replacing ctrl++ with ctrl+shift++

What about keyboard layouts where you can access + without shift (e.g. german
layout) ?
Comment 10 Christian Persch 2005-02-01 15:00:21 UTC
Comment on attachment 36807 [details] [review]
Its just a mater of replacing ctrl++ with ctrl+shift++

This doesn't work (I just tested it in german layout): when you can access +
without shift, pressing Shift-Ctrl-+ doesn't zoom, and Ctrl-+ zooms. So the
advertised accel doesn't work.
Comment 11 Sudhakar Naidu.A 2005-02-02 13:08:34 UTC
Created attachment 36868 [details] [review]
modified patch for id=36807

ok shift+ctrl++ wont work in german layout 

What about other layouts(like French,UK),where + can be accessed only using
shift key.So ctrl++ by using +/? will not work in such layouts.

So,it is better to use "ctrl+Up" and "ctrl+Down" to overcome this conflict.
Comment 12 Christian Persch 2005-02-02 19:58:53 UTC
The Ctrl-+ and Ctrl-- accels are mandated by the HIG
[http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#standard-shortcuts
Table 10.7], we cannot change them.

Bug 94910 is the relevant HIG bug discussing the problem with Ctrl-+. 
Comment 13 Vincent Noel 2005-02-16 22:29:52 UTC
AFAICS, this bug was about zooming in and out with the + and - on the numeric
keypad. The patch in attachment 26450 [details] [review] is still valid.
Should this bug be moved to gtk+ ? Marco ?
Comment 14 Marco Pesenti Gritti 2005-02-21 10:51:05 UTC
*** Bug 167634 has been marked as a duplicate of this bug. ***
Comment 15 Christian Persch 2005-03-02 22:22:30 UTC
Comment on attachment 36868 [details] [review]
modified patch for id=36807

This is contrary to the HIG, sorry.
Comment 16 Sergej Kotliar 2005-10-31 19:19:58 UTC
What is the status on this one?
Yes, it should go in to gtk, but since this exact same bug has been filed (and
already fixed) for many other GNOME apps (EOG, Evince are the ones I can
recall), this should be patched too.
When it reaches gtk perhaps the patch can be removed, but in the meantime
Epiphany has something that many users consider as broken, and so it should be
fixed.
Comment 17 Olivier Le Thanh Duong 2005-12-18 21:34:50 UTC
*** Bug 324416 has been marked as a duplicate of this bug. ***
Comment 18 Reinout van Schouwen 2005-12-29 12:51:11 UTC
Updating version fields. Chpe, does the patch still apply / can we have it for 1.10?
Comment 19 Olav Vitters 2005-12-29 20:08:21 UTC
*** Bug 315890 has been marked as a duplicate of this bug. ***
Comment 20 Christian Persch 2005-12-30 19:10:19 UTC
Fixed in cvs.