GNOME Bugzilla – Bug 262210
"new" toolbar button does not follow gnome settings
Last modified: 2013-09-13 00:51:19 UTC
Package: Evolution Priority: Cosmetic Version: GNOME2.2.2 1.4.6 os_details: GNOME.Org Synopsis: Missing Background for "New" button in main window Bugzilla-Product: Evolution Bugzilla-Component: UI Description: Description of Problem: The background behind the "New" button seems to be missing. It is just a flat color that appears different than the rest of the program. When you mouse over the button, an image does appear, however, it appears that it is not aligned with the text properly. Steps to reproduce the problem: 1. Install SuSE 9.0 FTP install 2. Install Ximian 1.4.6 3. ...It's pretty apparent after that. Actual Results: Background behind "New" button is missing or broken Expected Results: Cosmetic fix, just to make it look like the rest of the program. How often does this happen? Always Additional Information: I am running Ximian 1.4.6 running on SuSE 9.0 ftp install, of course using the default kde desktop that SuSE installs. This bug report filled out the Version as GNOME2.2.2 1.4.6 and os_details as GNOME.Org I have no clue why it would do that....but either way, I am running it with kde. Unknown reporter: finerdesign@gmail.com, changed to bugbuddy-import@ximian.com. Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
What theme are you using?
*** Bug 273586 has been marked as a duplicate of this bug. ***
This is still the case in 2.4.0, it happens with the default GNOME theme (clearlooks). Bug 273586 contains a screenshot of the problem. And it also contains a list of other themes that the new button is drawn badly in (Amaranth, glider, Lush)
Created attachment 51975 [details] [review] possible fix Only paint the button when it's depressed or prelighted, not always. The problem was introduced with the fix for bug 254503.
This patch doesn't fix the problem. Try Smooth-cool-blue or Crux with it and you'll see. It also breaks the button in the insensitive state.
assigning dobey's evo UI bugs to srag as he is the UI guy now. :-)
removing old target milestone
dobey: I donno, I applied the patch (Doesnt apply clean for me), it seems to be fine on clearlooks, Industrial and other themes that come default with the desktop. I donno know a scenario where that button will be disabled. It is used only in 'NEW' button only (IIRC) and that is always enabled. If something works on 80% of the scenario and reverses the current 20%, we should go for it IMO. Let me know your thoughts towards it.
The widget (and toolbar in general) really needs to be replaced with standard GTK+ stuff, rather than using bonobo and a custom widget hack, at some point, I think. As far as I could tell when I was looking at this last, the problem is basically not fixable in all cases, if I remember correctly. As far as testing the insensitive state goes, choose File->Quit from the menu, and you'll see the problems there.
Dobey: You are perfectly right, it hits us hard at a lot of places. We need to get away from the current toolbar. I tried testing the patch, it looks wierd in disabled mode (same as today in enabled mode). But this is OK than being wierd in the normal mode itself. I couldnt find issue in other scenarios. Can you recollect the other issues, if not I would prefer to get this in for now, till we move away from bonobo.
okay, seems like this is the bug where the discussion currently goes on, so i'm gonna mark all the dups here.
*** Bug 245342 has been marked as a duplicate of this bug. ***
*** Bug 254503 has been marked as a duplicate of this bug. ***
*** Bug 252814 has been marked as a duplicate of this bug. ***
Im gonna apply this to head. Since this shows off bad just in disabled state, and I see no great harm.
Fixed to HEAD.
*** Bug 346199 has been marked as a duplicate of this bug. ***
Are you sure it's completely fixed? Bugs marked as dup of this one also said the button uses a 16x16 pixmap as opposed to the rest of toolbar widgets.
I havent checked that yet. Will see that. But the original bug was about the not respecting the toolbar setting for showing icon/text.