After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165714 - GtkEntryCompletion doesn't complete on paste
GtkEntryCompletion doesn't complete on paste
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.6.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
: 110635 168822 170821 318263 322267 326286 341533 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-01-30 15:24 UTC by Christian Neumair
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (1.04 KB, patch)
2005-01-30 15:30 UTC, Christian Neumair
none Details | Review
Proposed patch. Only popup if entry is empty before pasting. (1.04 KB, patch)
2005-02-17 14:46 UTC, Christian Neumair
none Details | Review

Description Christian Neumair 2005-01-30 15:24:58 UTC
I consider it a major usability backdraw that GTK+ doesn't complete if I insert
text into a GtkEntryCompletion. I often paste URLs or a search term into the
Epiphany location bar and nothing happens where I'd expect a completion popup to
select among known pages.

Other information:
Comment 1 Christian Neumair 2005-01-30 15:30:12 UTC
Created attachment 36723 [details] [review]
Proposed patch.
Comment 2 Matthias Clasen 2005-02-01 20:00:26 UTC
I discussed this with the local human interaction designers, and they agreed
with me that it is better to not pop up the completion window on paste.
Comment 3 Christian Neumair 2005-02-02 15:43:23 UTC
Maybe you could paste a discussion snippet or point out some arguments for the
status quo, i.e. against popup-on-paste? Why does this proposal form a negative
usability impact?
My use-case is that I have a dictionary as search engine in my smart bookmarks.
Looking up a word would be as simple as Ctrl-N, Paste if this worked.
Comment 4 Christian Neumair 2005-02-05 14:45:00 UTC
No reply so far, reopening.
Comment 5 Matthias Clasen 2005-02-05 19:49:32 UTC
Sorry, I don't have any discussion snipplets backing up my opinion, but I do
remember that I asked Seth about this when somebody *complained* about the
original behaviour, which was popping up the completions on paste, and we agreed
that it would likely be more annoying than helpful in general. I think the
complained came from Anders...
Comment 6 Christian Neumair 2005-02-06 10:22:52 UTC
I still don't get how I can achieve what I want without doing cracky things like
typing a character and deleting it afterwards again. Pasting URIs in browsers is
very common, really.
Christian: Do you think it's a good idea to raise a discussion about this to
have a consistent behavior, or do you think hacking Ephy to do this is enough?
Comment 7 Christian Neumair 2005-02-06 10:41:11 UTC
Looks like GTK+ maintainers will kill whoever tries to use internal GTK+ symbols
like _gtk_entry_completion_popup :P. So we seriously have to discuss about it.
Comment 8 Christian Persch 2005-02-06 23:24:38 UTC
I'm against overriding this in epiphany; all entries with autocompletion in
GNOME should behave the same way wrt. paste. IMHO it should be discussed on
usability list.
Comment 9 Christian Neumair 2005-02-16 16:59:19 UTC
OK, so would it be reasonable to pop up if the entry is empty before pasting?
Comment 10 Christian Neumair 2005-02-17 14:46:30 UTC
Created attachment 37591 [details] [review]
Proposed patch. Only popup if entry is empty before pasting.
Comment 11 Christian Persch 2005-03-19 12:30:45 UTC
*** Bug 170821 has been marked as a duplicate of this bug. ***
Comment 12 Christian Persch 2005-03-20 16:48:36 UTC
*** Bug 110635 has been marked as a duplicate of this bug. ***
Comment 13 Gustavo Carneiro 2005-08-01 17:21:12 UTC
I was about to file this bug myself.  Already was looking at the code too.  It
really does look like a bug that paste doesn't trigger completion.  *Please* fix
this!  And the patch works fine here too.
Comment 14 Christian Neumair 2005-08-01 19:44:19 UTC
I'd really like to get some comments from the usability crew on this.
Comment 15 Calum Benson 2005-08-08 17:27:56 UTC
Well, all I can say is that the Safari web browser on OSX supports completion on
pasting, and I don't recall it ever causing a problem for me.  However, a
browser is just one particular application of a completing text field... we'd
need to think about all the places it was used in GNOME before coming to any
conclusions, I think.  Anyone care to compile a list?
Comment 16 Nigel Tao 2005-10-08 04:53:29 UTC
*** Bug 318263 has been marked as a duplicate of this bug. ***
Comment 17 Nigel Tao 2005-10-08 04:57:16 UTC
Previous dupe shows that deskbar-applet (as well as epiphany) is hoping for the
fix to be applied.
Comment 18 Christian Persch 2005-11-23 21:13:45 UTC
*** Bug 322267 has been marked as a duplicate of this bug. ***
Comment 19 Wouter Bolsterlee (uws) 2006-01-03 14:26:31 UTC
Is there any progress on this issue?
Comment 20 Christian Persch 2006-01-09 11:08:31 UTC
*** Bug 326286 has been marked as a duplicate of this bug. ***
Comment 21 Matthias Clasen 2006-01-10 04:12:00 UTC
2006-01-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.c (paste_received): Make GtkEntryCompletion
	complete on pastes at the end.  (#165714, Christian Neumair)
Comment 22 Josh Lee 2006-01-22 01:25:26 UTC
*** Bug 168822 has been marked as a duplicate of this bug. ***
Comment 23 Christian Persch 2006-07-23 13:17:49 UTC
*** Bug 341533 has been marked as a duplicate of this bug. ***
Comment 24 Christian Persch 2006-07-23 13:21:55 UTC
This is not fixed in gtk 2.10.

Steps to reproduce:
0) Start testentrycompletion
1) Set inline completion to FALSE for the 1st entry in its property editor
2) Paste "gno" (no quotes) into the 1st or 2nd entry.
3) Delete entry contents
4) Type "gno" into 1st or 2nd entry

Result:
In 2), no completion is shown; 4) shows completions.
Comment 25 Matthias Clasen 2006-08-16 17:42:54 UTC
2006-08-16  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.c (paste_received): Popup completion if paste
	is at the end (patch was already in 2.8.x).  (#165714, 
	Christian Persch)