GNOME Bugzilla – Bug 779128
games does not follow global themes
Last modified: 2017-06-16 10:08:11 UTC
Games does not follow global themes. It should look more uniform on systems where non-adwaita themes are used.
Created attachment 346562 [details] Games on "Ark" theme
Created attachment 346563 [details] Notes on "Ark" theme
Jimmac told on IRC this is being worked on for Photos. Some relevant bugs: https://bugzilla.gnome.org/show_bug.cgi?id=690623 https://bugzilla.gnome.org/show_bug.cgi?id=779073 https://bugzilla.gnome.org/show_bug.cgi?id=779074
Created attachment 347183 [details] [review] ui: Remove uses of custom CSS
Created attachment 347184 [details] [review] ui: Remove gtk-style.css
Created attachment 348232 [details] [review] ui: Add osd style to game thumbnail
Created attachment 351892 [details] [review] ui: Use theme relative colors for styling This allows Games to follow global themes. Furthermore, we will be able to support light themes and not be forced to set 'gtk-application-prefer-dark-theme' to 1.
Created attachment 351893 [details] [review] ui: Do not set 'prefer-dark-theme' for the Games This makes sure that users are not obligated to always use dark theme.
Review of attachment 351892 [details] [review]: LGTM.
Created attachment 351895 [details] arc-dark with relative color patch
Created attachment 351896 [details] flat-plat-dark with relative color patch
Created attachment 351903 [details] arc-light with relative color patch
Created attachment 351904 [details] flat-plat-light with relative color patch
Review of attachment 351893 [details] [review]: ::: src/ui/application.vala @@ -133,3 @@ protected override void activate () { - Gtk.Settings.get_default ().gtk_application_prefer_dark_theme = true; - We still want it by default, but i'm not against adding a option to set it off.
Comment on attachment 351892 [details] [review] ui: Use theme relative colors for styling Attachment 351892 [details] pushed as f605f61 - ui: Use theme relative colors for styling