After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779128 - games does not follow global themes
games does not follow global themes
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-23 12:14 UTC by Abhinav Singh
Modified: 2017-06-16 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Games on "Ark" theme (73.25 KB, image/png)
2017-02-23 12:35 UTC, Abhinav Singh
  Details
Notes on "Ark" theme (11.51 KB, image/png)
2017-02-23 12:35 UTC, Abhinav Singh
  Details
ui: Remove uses of custom CSS (1.88 KB, patch)
2017-03-04 03:01 UTC, Abhinav Singh
none Details | Review
ui: Remove gtk-style.css (1.64 KB, patch)
2017-03-04 03:01 UTC, Abhinav Singh
none Details | Review
ui: Add osd style to game thumbnail (823 bytes, patch)
2017-03-18 17:24 UTC, Abhinav Singh
none Details | Review
ui: Use theme relative colors for styling (1.38 KB, patch)
2017-05-15 14:58 UTC, Abhinav Singh
committed Details | Review
ui: Do not set 'prefer-dark-theme' for the Games (920 bytes, patch)
2017-05-15 15:37 UTC, Abhinav Singh
needs-work Details | Review
arc-dark with relative color patch (421.15 KB, image/png)
2017-05-15 15:45 UTC, Abhinav Singh
  Details
flat-plat-dark with relative color patch (419.35 KB, image/png)
2017-05-15 15:46 UTC, Abhinav Singh
  Details
arc-light with relative color patch (421.13 KB, image/png)
2017-05-15 16:44 UTC, Abhinav Singh
  Details
flat-plat-light with relative color patch (425.87 KB, image/png)
2017-05-15 16:44 UTC, Abhinav Singh
  Details

Description Abhinav Singh 2017-02-23 12:14:34 UTC
Games does not follow global themes. It should look more uniform on systems where non-adwaita themes are used.
Comment 1 Abhinav Singh 2017-02-23 12:35:34 UTC
Created attachment 346562 [details]
Games on "Ark" theme
Comment 2 Abhinav Singh 2017-02-23 12:35:58 UTC
Created attachment 346563 [details]
Notes on "Ark" theme
Comment 3 Adrien Plazas 2017-02-23 13:48:40 UTC
Jimmac told on IRC this is being worked on for Photos. Some relevant bugs:
https://bugzilla.gnome.org/show_bug.cgi?id=690623
https://bugzilla.gnome.org/show_bug.cgi?id=779073
https://bugzilla.gnome.org/show_bug.cgi?id=779074
Comment 4 Abhinav Singh 2017-03-04 03:01:17 UTC
Created attachment 347183 [details] [review]
ui: Remove uses of custom CSS
Comment 5 Abhinav Singh 2017-03-04 03:01:42 UTC
Created attachment 347184 [details] [review]
ui: Remove gtk-style.css
Comment 6 Abhinav Singh 2017-03-18 17:24:08 UTC
Created attachment 348232 [details] [review]
ui: Add osd style to game thumbnail
Comment 7 Abhinav Singh 2017-05-15 14:58:27 UTC
Created attachment 351892 [details] [review]
ui: Use theme relative colors for styling

This allows Games to follow global themes. Furthermore, we will be able
to support light themes and not be forced to set
'gtk-application-prefer-dark-theme' to 1.
Comment 8 Abhinav Singh 2017-05-15 15:37:55 UTC
Created attachment 351893 [details] [review]
ui: Do not set 'prefer-dark-theme' for the Games

This makes sure that users are not obligated to always use dark theme.
Comment 9 Adrien Plazas 2017-05-15 15:39:45 UTC
Review of attachment 351892 [details] [review]:

LGTM.
Comment 10 Abhinav Singh 2017-05-15 15:45:55 UTC
Created attachment 351895 [details]
arc-dark with relative color patch
Comment 11 Abhinav Singh 2017-05-15 15:46:40 UTC
Created attachment 351896 [details]
flat-plat-dark with relative color patch
Comment 12 Abhinav Singh 2017-05-15 16:44:02 UTC
Created attachment 351903 [details]
arc-light with relative color patch
Comment 13 Abhinav Singh 2017-05-15 16:44:47 UTC
Created attachment 351904 [details]
flat-plat-light with relative color patch
Comment 14 Adrien Plazas 2017-05-15 17:26:00 UTC
Review of attachment 351893 [details] [review]:

::: src/ui/application.vala
@@ -133,3 @@
 	protected override void activate () {
-		Gtk.Settings.get_default ().gtk_application_prefer_dark_theme = true;
-

We still want it by default, but i'm not against adding a option to set it off.
Comment 15 Adrien Plazas 2017-05-15 17:27:23 UTC
Comment on attachment 351892 [details] [review]
ui: Use theme relative colors for styling

Attachment 351892 [details] pushed as f605f61 - ui: Use theme relative colors for styling