Created attachment 346464 [details] [review]
Adwaita: style selectionmode checks for flowbox

Few irks a certain italian might find unacceptable:

- asset based rather than drawn with css machinery
- non-checked active pixmap seems to be blank
  (checkbox-active-selectionmode.png). Couldn't figure out why.

Created attachment 346465 [details] [review]
Adwaita: style selectionmode checks for flowbox

Few irks a certain italian might find unacceptable:

- asset based rather than drawn with css machinery
- non-checked active pixmap seems to be blank
  (checkbox-active-selectionmode.png). Couldn't figure out why.
- original selector has style a .check class, rather
  than the class node in the flowbox

I thought I had those styled already (big style class or something), or maybe I didn't push, lemme check that out before pushing.

I'd just point out that the GtkIconView/GtkTreeView based content-views (still used by Documents and other applications) are not using a GtkCheckButton. They are using a custom GtkCellRenderer, and those work with the "check" style class.

On the other hand, Photos uses the GtkFlowBox based content-view and it uses a GtkCheckButton with the usual "checkbutton check" CSS nodes.

It would be nice to retain support for both scenarios until all applications have been ported.

Review of attachment 346465 [details] [review]:

please, just push theme fixes that you and the Italian agree on

Review of attachment 346465 [details] [review]:

please, just push theme fixes that you and the Italian agree on

(In reply to Jakub Steiner from comment #2)
> Created attachment 346465 [details] [review] [review]
> Adwaita: style selectionmode checks for flowbox
> 
> Few irks a certain italian might find unacceptable:
>
> [...]
>
> - original selector has style a .check class, rather
>   than the class node in the flowbox

The original selector used the "check" CSS style class because the GtkIconView/GtkTreeView based content-views (still used by Documents and other applications) are not using a GtkCheckButton. They are using a custom GtkCellRenderer from libgd. We need to retain compatibility for a while. See comment 4.

I can confirm that this patch has the desired effect on the GtkFlowBox-based gnome-photos.

Created attachment 347051 [details] [review]
Adwaita: style selectionmode checks for flowbox tiles

- continue being asset based rather than drawn by CSS
- using node 'check' rather than style '.check'

Attachment 347051 [details] pushed as fc81dc1 - Adwaita: style selectionmode checks for flowbox tiles