After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779073 - style flowbox tiles
style flowbox tiles
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Lapo Calamandrei
gtk-bugs
Depends on:
Blocks: 777869
 
 
Reported: 2017-02-22 15:02 UTC by Jakub Steiner
Modified: 2017-03-02 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adwaita: style flowbox tiles (2.45 KB, patch)
2017-02-22 15:03 UTC, Jakub Steiner 		none Details | Review
Adwaita: style flowbox tiles (3.49 KB, patch)
2017-02-23 14:05 UTC, Jakub Steiner 		none Details | Review
Adwaita: style flowbox tiles (3.50 KB, patch)
2017-02-23 15:48 UTC, Jakub Steiner 		committed Details | Review

Description Jakub Steiner 2017-02-22 15:02:55 UTC 
Core apps are slowly phasing out icon grids with flowbox. It would be nice to have the dark variant of Adwaita provide passpartout on the tiles for aspect-ratio-conforming fit (background-sclae: contain; in css speak).

For light theme I'd keep the background fully transparent as documents don't have to tone down the surrounding and they are all usually same paper size and portrait. Letterboxing documents would feel a little odd maybe.
Comment 1 Jakub Steiner 2017-02-22 15:03:19 UTC 
Created attachment 346449 [details] [review]
Adwaita: style flowbox tiles
Comment 2 Emmanuele Bassi (:ebassi) 2017-02-22 15:08:27 UTC 
Review of attachment 346449 [details] [review]:

::: gtk/theme/Adwaita/gtk-contained-dark.css
@@ +104,3 @@
+.content-view .tile {
+  margin: 2px;
+  background-color: black;

This doesn't seem to be correct; you're darkening the base color 20%, but this is full on black?
Comment 3 Lapo Calamandrei 2017-02-22 15:42:05 UTC 
Emmanuele is right, better to just use Black in that case, it's more readable.
Looks good to me, what about the other states though? Are you relying in the flowboxchild styling foto those? I think foto the dark variant the backdrop state should be styled, since that Black would probably stand out too much.
Comment 4 Jakub Steiner 2017-02-23 14:05:56 UTC 
Created attachment 346570 [details] [review]
Adwaita: style flowbox tiles
Comment 5 Jakub Steiner 2017-02-23 15:48:14 UTC 
Created attachment 346582 [details] [review]
Adwaita: style flowbox tiles
Comment 6 Matthias Clasen 2017-03-01 11:52:41 UTC 
Review of attachment 346582 [details] [review]:

ok then, artists get to decide on the art!. no need to wait for anything here
Comment 7 Jakub Steiner 2017-03-02 11:32:37 UTC 
Attachment 346582 [details] pushed as 8817c1a - Adwaita: style flowbox tiles