GNOME Bugzilla – Bug 690623
Port to GtkFlowBox
Last modified: 2017-03-22 19:25:14 UTC
In the photo overview (icon view) there is twice as much space between photos as there is between the photos and the edge of the view. I think they should be equal.
The ability to adapt the spacing between the columns as the window size changes, like a flowing layout, looks related to bug 460044 Or am I missing something? I recently changed the default size of the window to 960x600 (org.gnome.photos window-size): http://git.gnome.org/browse/gnome-photos/commit/?id=7f5d856fa3260fa0d2e0b7ce94d0c872279714a2
Created attachment 232095 [details] screenshot
We need EggFlowBox for this.
I have a lot of blank space inbetween elements, especially on the right. (Is the grid left aligned by default?) I'm not a developer but would a responsive grid not be possible? Maximizing horizontal window space usage.
(In reply to comment #4) > I have a lot of blank space inbetween elements, especially on the right. (Is > the grid left aligned by default?) That is just how GtkIconView behaves. > I'm not a developer but would a responsive grid not be possible? Maximizing > horizontal window space usage. Yes, we need to use GtkFlowBox as a replacement.
i am interested in taking this up.Will i have to replace the complete GtkIconView code with that of GtkFlowBok?
The changes in bug 770342 has reduced our dependence on GtkTreeModel. It should help with this.
Created attachment 341638 [details] [review] Update to latest libgd
Created attachment 341639 [details] [review] base-item: Implement GdMainBoxItem
Created attachment 341640 [details] [review] Port to GdMainBox
Created attachment 341750 [details] [review] Update to latest libgd
Created attachment 341751 [details] [review] base-item: Implement GdMainBoxItem
Created attachment 341752 [details] [review] Port to GdMainBox
Created attachment 343288 [details] [review] Move the code to update the OffsetControllers' count
Created attachment 343362 [details] [review] item-manager: Shuffle some code around
Created attachment 343363 [details] [review] item-manager: Add mechanism for constraining item additions
Created attachment 343364 [details] [review] tracker-controller, view-model: Move policy to constrain item additions
Created attachment 343365 [details] [review] item-manager: Style fix
Created attachment 343373 [details] [review] Port to GdMainBox
Created attachment 343374 [details] [review] Update to latest libgd Need to bump the GTK+ requirement for new GtkFlowBox API.
Created attachment 343497 [details] [review] Remove unused file Fallout from commit 528c556318248bb4e420d012ee14aabcd14dde71
Review of attachment 343497 [details] [review]: Good catch! It got dropped from the commit due to a conflict when I was rebasing the patches. I should have been more careful.
Comment on attachment 343497 [details] [review] Remove unused file Attachment 343497 [details] pushed as 12613d3 - Remove unused file
*** Bug 756778 has been marked as a duplicate of this bug. ***