After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779252 - "Memory" and "Maximum Disk Size" headings should use bold text
"Memory" and "Maximum Disk Size" headings should use bold text
Status: RESOLVED OBSOLETE
Product: gnome-boxes
Classification: Applications
Component: properties
unspecified
Other Linux
: Normal enhancement
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-26 13:34 UTC by Felipe Borges
Modified: 2018-01-11 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 77952 patch - newcomers (2.26 KB, patch)
2017-07-03 14:27 UTC, Thiago
none Details | Review
A new patch keeping the strings the way they are so the translation will not be lost. (788 bytes, patch)
2017-07-04 17:14 UTC, Thiago
needs-work Details | Review

Description Felipe Borges 2017-02-26 13:34:43 UTC
As suggested in Bug 746478, the "Memory" and "Maximum Disk Size" headings should use bold text (because they're headings). See the wanted result in the screenshot (right side) https://bug746478.bugzilla-attachments.gnome.org/attachment.cgi?id=299865
Comment 1 Thiago 2017-07-01 21:44:11 UTC
Checking the oficial release and the master right now and in both cases the data coming right after the headings are not aligned to the right of the screen. Both cases the info comes right next to the headings (Memory and Max Disk Size).

 If I check the screenshot that shows me the wanted result it has the data info aligned at the left side of the screen. 

How does it should look like after the changes?

1)
-------------------------------------------------
-- Memory: 2Gib                                --
-------------------------------------------------

or

2)
-------------------------------------------------
-- Memory:                                2Gib --
-------------------------------------------------
Comment 2 Felipe Borges 2017-07-03 09:56:20 UTC
I would keep them aligned in the left for now. The purpose in this design, I guess, was to have the numbers right on top of the GtkScale mark, but it creates this visual glimpse perception that the numbers are floating horizontally.

TL;DR: I would keep the values at the left for now.

The strings in the $SUBJECT still should be bold.
Comment 3 Thiago 2017-07-03 14:27:57 UTC
Created attachment 354837 [details] [review]
Bug 77952 patch - newcomers

Wondering about the approach used here.

Setting the string at the file libvirt-machine-properties.vala as <b>...</b>.

Checking the rest of the code I could see this project using a different approach to change the style of a few strings. 

1) "size_str = "<small>" + size_str + "</small>";" 

Wondering which one I should use. Concatenating strings or just adding the 

2) "<b></b>" 

to the main string like I did.

I choose the second approach because it is more optimized than the first one.

Thiago
Comment 4 Felipe Borges 2017-07-04 10:27:37 UTC
The downside of the second approach, and the reasoning behind us using the first, is that this way you end up offering translators a string with markup language. This is an internal implementation/design which shouldn't be delegated to translators.

I grep-ed through the po/ folder and found several markup strings in translations. So I will open a new newcomers bug for that, so different/separated patches can be send. See Bug 784507
Comment 5 Thiago 2017-07-04 13:07:06 UTC
Felipe. 

Totally agree with not leaving the markup language to the translators. I was just wondering because I saw both implementantions 7so in that case I took the most optimized. I'm gonna work in the Bug 784507 and after that I'm back to this one and the others I was checking together.

Thanks for your help :)
Comment 6 Thiago 2017-07-04 17:14:58 UTC
Created attachment 354895 [details] [review]
A new patch keeping the strings the way they are so the translation will not be lost.

A new patch keeping the strings the way they are so the translation will not be lost.
Comment 7 Felipe Borges 2017-09-04 10:23:29 UTC
Review of attachment 354895 [details] [review]:

That's it.

Please write a proper commit message.
Comment 8 GNOME Infrastructure Team 2018-01-11 10:50:10 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/127.