GNOME Bugzilla – Bug 746478
system tab - minor visual fixes
Last modified: 2017-03-08 15:02:16 UTC
Created attachment 299865 [details] modified screenshot Today I was shown a screenshot of the system tab in the properties dialog, and I saw quite a few rough edges: * Uneven vertical padding between sections (not enough padding above graphs, above and buttons - I'd recommend using about 40px for each). * "Troubleshooting log" should use header capitalisation (as should all button labels) - "Troubleshooting Log". * "Memory" and "Maximum Disk Size" headings should use bold text (because they're headings). * "(maximum)" text at the end of each slider seems superfluous - it's the end of the slider; this already communicates that it's the maximum. * The values for the current memory and disk allocations are floating in space - they should be right aligned with the rest of the values. * There are some slight issues with the alignment of the sliders, compared with the other widgets - on the left, they don't quite align with the buttons, on the right, nothing quite lines up with the graph above. The screenshot is attached, alongside a modified version (which on the right), to illustrate the suggested changes.
Created attachment 346754 [details] screenshot: Properties dialog (In reply to Allan Day from comment #0) > Created attachment 299865 [details] > modified screenshot > > Today I was shown a screenshot of the system tab in the properties dialog, > and I saw quite a few rough edges: > > * Uneven vertical padding between sections (not enough padding above > graphs, above and buttons - I'd recommend using about 40px for each). > > * "Troubleshooting log" should use header capitalisation (as should all > button labels) - "Troubleshooting Log". These seem to be fixed (see screenshot), and please give me an ACK. > * "Memory" and "Maximum Disk Size" headings should use bold text (because > they're headings). I filed an individual bug for this one with the 'newcomers' keyword so we can have more entry bugs for new comers. See Bug 779252 > * "(maximum)" text at the end of each slider seems superfluous - it's the > end of the slider; this already communicates that it's the maximum. Another 'newcomers' Bug 779253 > * The values for the current memory and disk allocations are floating in > space - they should be right aligned with the rest of the values. These are now aligned left, next to the headings. Is it wanted like this? > * There are some slight issues with the alignment of the sliders, compared > with the other widgets - on the left, they don't quite align with the > buttons, on the right, nothing quite lines up with the graph above. This is also on GtkScale: the mark label is not constrained by the slider width. Also quite straightforward to patch on gtk+, if wanted. ================= I also noticed that you dropped the Scale marks "|" in the modified screenshot. This is part of the GtkScale widget in gtk+ nowadays and it doesn't have a property to hide it. A patch in gtk+ for introducing such a thing should be quite simple, since the mark has a subnode named 'indicator' and another one for the label. Anyhow, is it wanted?
(In reply to Felipe Borges from comment #1) > Created attachment 346754 [details] > screenshot: Properties dialog > > (In reply to Allan Day from comment #0) > > Created attachment 299865 [details] > > modified screenshot > > > > Today I was shown a screenshot of the system tab in the properties dialog, > > and I saw quite a few rough edges: > > > > * Uneven vertical padding between sections (not enough padding above > > graphs, above and buttons - I'd recommend using about 40px for each). > > > > * "Troubleshooting log" should use header capitalisation (as should all > > button labels) - "Troubleshooting Log". > > These seem to be fixed (see screenshot), and please give me an ACK. Looks really good, although the capitalisation of Troubleshooting Log hasn't been fixed in the screenshot. > > * The values for the current memory and disk allocations are floating in > > space - they should be right aligned with the rest of the values. > > These are now aligned left, next to the headings. Is it wanted like this? In the screenshot you posted they are right aligned - that seems good. > > * There are some slight issues with the alignment of the sliders, compared > > with the other widgets - on the left, they don't quite align with the > > buttons, on the right, nothing quite lines up with the graph above. > > This is also on GtkScale: the mark label is not constrained by the slider > width. Also quite straightforward to patch on gtk+, if wanted. It certainly looks better in the screenshot. Could be nice to for GTK+ too. > I also noticed that you dropped the Scale marks "|" in the modified > screenshot. This is part of the GtkScale widget in gtk+ nowadays and it > doesn't have a property to hide it. A patch in gtk+ for introducing such a > thing should be quite simple, since the mark has a subnode named 'indicator' > and another one for the label. Anyhow, is it wanted? I'm not too concerned about the scale marks - they could be left.
Thanks for your feedback. (In reply to Allan Day from comment #2) > (In reply to Felipe Borges from comment #1) > > Created attachment 346754 [details] > > screenshot: Properties dialog > > > > (In reply to Allan Day from comment #0) > > > Created attachment 299865 [details] > > > modified screenshot > > > > > > Today I was shown a screenshot of the system tab in the properties dialog, > > > and I saw quite a few rough edges: > > > > > > * Uneven vertical padding between sections (not enough padding above > > > graphs, above and buttons - I'd recommend using about 40px for each). > > > > > > * "Troubleshooting log" should use header capitalisation (as should all > > > button labels) - "Troubleshooting Log". > > > > These seem to be fixed (see screenshot), and please give me an ACK. > > Looks really good, although the capitalisation of Troubleshooting Log hasn't > been fixed in the screenshot. It is fixed now on master. I'm closing this one bug now since the small tweaks proposed here were split up in newcomers bugs.