After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774644 - Untranslated string in the windows panel
Untranslated string in the windows panel
Status: RESOLVED OBSOLETE
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on: 785610
Blocks:
 
 
Reported: 2016-11-17 20:14 UTC by Piotr Drąg
Modified: 2018-01-24 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Attempted fix (6.49 KB, text/plain)
2016-12-09 12:38 UTC, Vitor Santos
  Details
windows: Fix ngettext string (1.11 KB, patch)
2017-03-19 17:54 UTC, Piotr Drąg
rejected Details | Review

Description Piotr Drąg 2016-11-17 20:14:28 UTC
"Settings will be reverted in %d second" in gtweak/tweaks/tweak_group_windows.py is marked for translation (with ngettext), but it shows up untranslated in the UI.
Comment 1 Vitor Santos 2016-12-09 12:38:37 UTC
Created attachment 341672 [details]
Attempted fix

Simple change to the function call to a newer version that takes system encoding into consideration, might fix it.
Comment 2 Rui Matos 2016-12-09 14:22:12 UTC
(In reply to Vitor Santos from comment #1)
> Created attachment 341672 [details]
> Attempted fix
> 
> Simple change to the function call to a newer version that takes system
> encoding into consideration, might fix it.

Can you attach that as a git formatted patch, or at least as a diff?
Comment 3 Piotr Drąg 2017-03-19 17:54:50 UTC
Created attachment 348266 [details] [review]
windows: Fix ngettext string

Vitor’s fix as a git patch. I have not tested it.
Comment 4 Piotr Drąg 2017-05-25 13:17:28 UTC
I gave the patch a test and it didn’t work, as far as I can tell.
Comment 5 Jeremy Bicha 2017-06-08 03:19:35 UTC
Comment on attachment 348266 [details] [review]
windows: Fix ngettext string

This commit does not fix the bug. Did you try this patch before submitting it?
Comment 6 Piotr Drąg 2017-07-03 21:30:05 UTC
I’m adding Robert to CC, who added ngettext to gnome-tweak-tool in bug #742491.

Robert, could you please take a look to why it doesn’t work?
Comment 7 Piotr Drąg 2017-08-10 18:18:00 UTC
While bug #785610 has been marked as FIXED, the actual commit 34d6d451d7c25482c65c09220ef979aae8101d9d did not remove the string in question from the code base.
Comment 8 Jeremy Bicha 2017-09-30 17:24:29 UTC
Yes, I didn't remove the string yet because HiDPI support in GNOME is still a bit incomplete.
Comment 9 GNOME Infrastructure Team 2018-01-24 15:17:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-tweaks/issues/81.