After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742491 - Plural forms in the countdown
Plural forms in the countdown
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-06 23:10 UTC by Marek Černocký
Modified: 2015-01-07 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use ngettext in settings revert warning (2.06 KB, patch)
2015-01-07 16:30 UTC, Robert Roth 		reviewed Details | Review
Use ngettext in settings revert warning (2.03 KB, patch)
2015-01-07 17:21 UTC, Robert Roth 		committed Details | Review

Description Marek Černocký 2015-01-06 23:10:20 UTC 
Message

"Settings will be reverted in %d seconds"

in countdown take no account of plural forms.
Comment 1 Robert Roth 2015-01-07 16:30:43 UTC 
Created attachment 294046 [details] [review]
Use ngettext in settings revert warning
Comment 2 Rui Matos 2015-01-07 17:06:23 UTC 
Review of attachment 294046 [details] [review]:

Please factor this into a helper function so that we don't need to have the strings repeated. Fine to push with that change
Comment 3 Rui Matos 2015-01-07 17:10:09 UTC 
Review of attachment 294046 [details] [review]:

::: gtweak/tweaks/tweak_group_windows.py
@@ +81,3 @@
+        self._second_message = gettext.ngettext(_("Settings will be reverted in %d second"),
+                                                _("Settings will be reverted in %d seconds"),
+                                                self._countdown);

drop the ;
Comment 4 Robert Roth 2015-01-07 17:21:58 UTC 
Created attachment 294049 [details] [review]
Use ngettext in settings revert warning
Comment 5 Robert Roth 2015-01-07 17:22:43 UTC 
Pushed the patch with the requested changes.
Attachment 294049 [details] pushed as d2085e4 - Use ngettext in settings revert warning
Comment 6 Marek Černocký 2015-01-07 19:30:32 UTC 
This code calls gettext (macro _ ) inside ngettext.
I fixed this omission in git.
Comment 7 Robert Roth 2015-01-07 19:57:30 UTC 
Whoops, thanks for spotting that.