After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755483 - Some directory selections result in an infinite loop when deep-counting
Some directory selections result in an infinite loop when deep-counting
Status: RESOLVED INCOMPLETE
Product: nautilus
Classification: Core
Component: File Properties Dialog
3.24.x
Other All
: Normal normal
: future
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 696383 754505 757234 777856 780557 782444 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-09-23 17:12 UTC by Pablo Rodríguez
Modified: 2018-05-26 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
~/Videos properties (20.65 KB, image/png)
2016-07-07 13:20 UTC, Ernestas Kulik 		Details
Properties of two symlinks to ~/Videos (19.49 KB, image/png)
2016-07-07 13:21 UTC, Ernestas Kulik 		Details

Description Pablo Rodríguez 2015-09-23 17:12:51 UTC 
I get an endless loop when trying to show information from all directories contained in my ~/.config directory.

The bug isn’t specific to that directory, but it seems to be triggered when the directory contains a number of subdirectories and files.

Steps to reproduce:

1. Open ~/.config/ in nautilus.

2. Select all folders and files pressing Ctrl+A.

3. Show information with Ctrl+I.

4. I get an endless loop. I have to close the Properties Window to exit the loop.

Could you confirm this bug and fix it?

Many thanks for your help,


Pablo
Comment 1 Pablo Rodríguez 2015-09-23 17:18:24 UTC 
I have just discovered that there is no loop when I press Control+I with the single folder ~/.config selected.

It seems to be a bug to me.
Comment 2 Ernestas Kulik 2016-07-04 13:41:50 UTC 
*** Bug 754505 has been marked as a duplicate of this bug. ***
Comment 3 Ernestas Kulik 2016-07-04 13:42:19 UTC 
*** Bug 757234 has been marked as a duplicate of this bug. ***
Comment 4 Ernestas Kulik 2016-07-04 13:46:05 UTC 
I can reproduce with /lib and /lib64 in master consistently.
Comment 5 Ernestas Kulik 2016-07-07 13:19:49 UTC 
I looked into this and sort of figured it out. At least in my case, it’s related to both directories being symlinks to the same directory (/lib -> /usr/lib, /lib64 -> /usr/lib). The deep count for the first one gets calculated, then the code starts calculating it for the second one and the first one resets. Repeat ad infinitum.

That I kind of sort of fixed by checking if the file is a symlink and comparing target locations (so there are only unique paths in the list) somewhere in here: https://git.gnome.org/browse/nautilus/tree/src/nautilus-properties-window.c#n976
I’m not too happy with the performance implications with that approach, however.

There is another problem (from my perspective): the sizes add up with symlinks. I’ll attach illustrations.
Comment 6 Ernestas Kulik 2016-07-07 13:20:41 UTC 
Created attachment 330997 [details]
~/Videos properties
Comment 7 Ernestas Kulik 2016-07-07 13:21:18 UTC 
Created attachment 330998 [details]
Properties of two symlinks to ~/Videos
Comment 8 Ernestas Kulik 2016-10-17 07:22:09 UTC 
*** Bug 773068 has been marked as a duplicate of this bug. ***
Comment 9 Andrea Vai 2016-10-17 07:25:12 UTC 
I'm not sure that Bug 773068 is a duplicate because I experience the bug in a folder structure without symlinks
Comment 10 Ernestas Kulik 2017-01-28 06:07:11 UTC 
*** Bug 777856 has been marked as a duplicate of this bug. ***
Comment 11 Ernestas Kulik 2017-03-26 08:12:53 UTC 
*** Bug 780557 has been marked as a duplicate of this bug. ***
Comment 12 Ernestas Kulik 2017-05-10 14:37:23 UTC 
*** Bug 782444 has been marked as a duplicate of this bug. ***
Comment 13 António Fernandes 2017-08-23 17:26:47 UTC 
*** Bug 696383 has been marked as a duplicate of this bug. ***
Comment 14 António Fernandes 2018-05-05 23:04:44 UTC 
Duplicate at GitLab https://gitlab.gnome.org/GNOME/nautilus/issues/363
Comment 15 António Fernandes 2018-05-26 10:28:31 UTC 
Let's move this bug to GitLab and close here.
https://gitlab.gnome.org/GNOME/nautilus/issues/363