After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748774 - Act on encrypt-by-default from ESourceOpenPGP
Act on encrypt-by-default from ESourceOpenPGP
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 232841 (view as bug list)
Depends on: 748770
Blocks:
 
 
Reported: 2015-05-01 21:30 UTC by Daniel Kahn Gillmor
Modified: 2016-03-11 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use encrypt-by-default from ESourcePGP (2.76 KB, patch)
2015-05-01 21:30 UTC, Daniel Kahn Gillmor 		needs-work Details | Review

Description Daniel Kahn Gillmor 2015-05-01 21:30:21 UTC 
Created attachment 302736 [details] [review]
use encrypt-by-default from ESourcePGP

#748770 implements an encrypt-by-default option for ESourceOpenPGP.

The attached patch makes use of that option to set the user's default composer window properly, and also exposes the option in the settings dialog.

It should apply against the current evolution master branch (470fe26fef540c899e57d73e9f23e7bf9743cd04)

(i've filed this under "Mailer" because it's about message creation and preferences, and "Composer" seems to be about the HTML editor.  Feel free to re-file it if i've chosen the wrong component)
Comment 1 Milan Crha 2015-05-05 14:37:30 UTC 
Review of attachment 302736 [details] [review]:

Thanks for a bug report and patch. There are some issues, which I'll fix before committing.

::: mail/e-mail-config-security-page.c
@@ +464,3 @@
 		G_BINDING_BIDIRECTIONAL);
 
+	text = _("_Always encrypt outgoing messages when using this account");

the mnemonic is clashing with another widget

@@ +467,3 @@
+	widget = gtk_check_button_new_with_mnemonic (text);
+	gtk_widget_set_margin_left (widget, 12);
+	gtk_grid_attach (GTK_GRID (container), widget, 0, 3, 2, 1);

this makes the check button overlap with another one in the UI
Comment 2 Milan Crha 2015-05-05 14:46:58 UTC 
Created commit c35c00a in evo master (3.17.2+)
Comment 3 Milan Crha 2016-03-11 11:43:08 UTC 
*** Bug 232841 has been marked as a duplicate of this bug. ***