After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748770 - Add "encrypt-by-default" property to ESourceOpenPGP
Add "encrypt-by-default" property to ESourceOpenPGP
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 748774
 
 
Reported: 2015-05-01 20:27 UTC by Daniel Kahn Gillmor
Modified: 2015-05-05 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add encrypt-by-default to ESourceOpenPGP (4.32 KB, patch)
2015-05-01 20:27 UTC, Daniel Kahn Gillmor
reviewed Details | Review

Description Daniel Kahn Gillmor 2015-05-01 20:27:35 UTC
Created attachment 302735 [details] [review]
add encrypt-by-default to ESourceOpenPGP

ESourceOpenPGP has a "sign-by-default" feature, but no
"encrypt-by-default".

By comparison, ESourceSMIME has both options.

The attached patch gives the plugins feature parity.
Comment 1 Daniel Kahn Gillmor 2015-05-01 20:30:32 UTC
The patch should be applicable to the current master of evolutiondataserver (e68fa19e880bc8990183fab38b74d9af79b3f75f)
Comment 2 Milan Crha 2015-05-05 14:23:12 UTC
Review of attachment 302735 [details] [review]:

Thanks for the bug report and patch. It looks fine, I'll only update the "Since:" tags in the devel-docs comments to 3.18.
Comment 3 Daniel Kahn Gillmor 2015-05-05 14:27:19 UTC
Whoops, yes, the Since: tag was a copy-paste fail on my part.  Thanks for correcting it.
Comment 4 Milan Crha 2015-05-05 14:41:25 UTC
Err, I'm sorry, I accidentally committed your change as mine. I'm sorry for that mistake :(

Create commit 8b21c88 in eds master (3.17.2+)