GNOME Bugzilla – Bug 747490
gnome disk utility lacks accessible labels for some of its controlls
Last modified: 2017-03-22 16:08:14 UTC
gnome disks lacks accessible labels for the following controlls. The volumes list is silent with orca. This looks visually like a grid of icons, so they should be fairly simple to label. The set of buttons just past the volumes list. The farthest left is to unmount the partition, the middle onedeletes the partition, and the last one brings up a menu for adding, editing, creating and restoring a partition image, etc. Please provide accessible labels with orca so these controlls can be read aloud. Lastly, the menu button is labeled, but would it be possible to give it a friendlier name? Maybe something like options menu? I'm not sure what to call it.
has there been any work on this, either for gnome 3.16 or the upcoming gnome 3.18? Trying to tally up all my bugs that have been fixed and ping those that haven't yet
*** This bug has been marked as a duplicate of bug 738150 ***
This is not an exact duplicate because "The volumes list is silent with orca" -- those need accessible labels indeed. The buttons missing tooltips will be fixed in bug #738150, though.
Aaaand the "buttons" in the partition view are not actual buttons, so adding tooltips to them does not fix the accessibility problem in itself....
(In reply to Michael Catanzaro from comment #4) > Aaaand the "buttons" in the partition view are not actual buttons, so adding > tooltips to them does not fix the accessibility problem in itself.... Actually they are normal GtkToolButtons....
I have no plans to change the grid to a list, but I like Allan's design, so "patches accepted." It is too late for 3.18 though; that would be 3.20 material. I think it should be possible to make the existing grid accessible, though.
I'm going to try working on a patch to implement that mockup. I haven't touched Gnome/Gtk stuff in a while though, so no guesses on how long it takes me. :)
(In reply to Nicholas Bishop from comment #7) > I'm going to try working on a patch to implement that mockup. I haven't > touched Gnome/Gtk stuff in a while though, so no guesses on how long it > takes me. :) Thanks a bunch. Please use the other bug (with the mockups) for this. For this bug, we'll just focus on the immediate accessibility issues. I have a patch for the volumes grid. Could you try it out, Kendell? And Joanie, could you look it over please? The toolbuttons beneath the volumes grid are still inaccessible.
Created attachment 309985 [details] [review] GduVolumeGrid: GridElement should hold text, not markup I see no reason why markup could ever possibly get into this variable, so rename it to text and use the appropriate pango function for text. This allows us to reuse this text for the grid's accessible name. If somehow we wind up with markup appearing in the grid, then we'll need to revisit this, but I think it's safe....
Created attachment 309986 [details] [review] GduVolumeGrid: Add basic accessibility I bet this is still almost impossible to use, if you don't know to use the arrow keys to move around the partition table, but at least now you can hear what the partions are, you have some chance. Further improvement probably needed. P.S. Yes, this is a hack. But it works just fine in Orca.
I'd be glad to test the patch. How would I go about this? git apply filename.patch in the gnome disk utility git tree? Right now I'm tracking the master branch, but I can easily switch to thee gnome-3-16 branch if needed
I've just tested both patches and it's an enormous improvement. It's just a tad verbose but nowhere near enough to cause annoyance. It says "volumes" after every arrow key pressed but again, not a big deal. This is fantastic. I can't speak to the code quality but it definitely improved accessibility
Attachment 309985 [details] pushed as 9ed7541 - GduVolumeGrid: GridElement should hold text, not markup Attachment 309986 [details] pushed as 422b04b - GduVolumeGrid: Add basic accessibility
Kendell, could you test this patch too, please? For some reason I'm having trouble using Orca today; I can't hear anything at all. :(
Created attachment 310205 [details] [review] Use the first grid element for the initial accessible name of the grid Instead of "Volumes Grid", so the user doesn't have to switch to another grid element and back to read the first partition, and so that it is possible to read the first partition when there is only one partition.
sure thing. Which patch? I've tested both the previous ones you committed, the one that changed the grid to hold text, not markup and the one that added basic accessibility. Was there another one? If so I'll grab it and test, no problem.
Please test the patch in comment #14, thanks :) I dunno why my Orca has stopped working :(
I hate to be the bearer of bad news, but this patch doesn't seem to fix the issue. I've tested on a drive with only one partition and the volumes grid just says "vomumes grid panel" without reading the partition. If I test on a drive with multiple partitions I can read the partitions so accessibility isn't broken, it just doesn't read the first partition until I've arrowed away from and back to the icon that represents it.
The following fix has been pushed: a3b0707 Use the first grid element for the initial accessible name of the grid Thanks for catching the bug. I fixed it and tested in accerciser.
Created attachment 310280 [details] [review] Use the first grid element for the initial accessible name of the grid Instead of "Volumes Grid", so the user doesn't have to switch to another grid element and back to read the first partition, and so that it is possible to read the first partition when there is only one partition. Also, use gdu_volume_grid_get_no_media_string() for the accessible name when appropriate.