After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748924 - Orca announces some buttons as button
Orca announces some buttons as button
Status: RESOLVED DUPLICATE of bug 754249
Product: gnome-disk-utility
Classification: Core
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-05 03:09 UTC by Alfonzo
Modified: 2017-03-22 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workaround: duplicate tooltip text to label properties (6.62 KB, patch)
2017-03-21 22:44 UTC, Kai Lüke 		none Details | Review
Add ATK properties (48.32 KB, patch)
2017-03-22 13:45 UTC, Kai Lüke 		rejected Details | Review

Description Alfonzo 2015-05-05 03:09:54 UTC 
Under Gnome 3.16, with Orca 3.16, there are buttons that are just announced as button.

The button next to the menu button is announced as button, and the buttons that are under the volume readout are announced as buttons.

Steps to Reproduce 

Launch Orca

Go to Disks

Hit the Tab key and Orca will announce the unlabelled buttons as Buttons.
Comment 1 Kai Lüke 2017-03-21 22:44:43 UTC 
Created attachment 348450 [details] [review]
workaround: duplicate tooltip text to label properties

In case this is something which won't be covered by orca in the next release here is a patch with a workaround by adding label properties.
Comment 2 Michael Catanzaro 2017-03-21 23:18:13 UTC 
Review of attachment 348450 [details] [review]:

Thanks, but this is not right: the label text is the text that's intended to be displayed to users next to the icon. It's ignored in this case since these are icon-only properties. I'd rather just leave this broken until we figure out what the best-practice is here.
Comment 3 Kai Lüke 2017-03-22 13:45:58 UTC 
Created attachment 348485 [details] [review]
Add ATK properties

Yes, I thought it would be better than adding an ATK property because they are read out as panel push buttons (which confused me first), but maybe this is the way to go.

So here the first commit adds these properties by just doing what Glade would do without updating the whole UI file. But just extracting this does not work (icons hidden), so the second commit is just an open-save action in Glade (icons are shown again).
Comment 4 Michael Catanzaro 2017-03-22 15:42:34 UTC 
Comment on attachment 348485 [details] [review]
Add ATK properties

Thanks for your dedication to fixing this, but it's nuts to duplicate the tooltip. This needs to be fixed in GTK+ or in Orca, one or the other. We can push this and fix Disks, but that's not going to do any good for all the other GNOME applications that remain inaccessible due to this issue.
Comment 5 Michael Catanzaro 2017-03-22 16:08:37 UTC 
Maybe this is a duplicate of bug #754249?
Comment 6 Michael Catanzaro 2017-03-22 16:13:31 UTC 
Pretty sure it is. I have a (flawed, needs updated) patch there that -- if I'm remembering correctly -- fixes this issue.

*** This bug has been marked as a duplicate of bug 754249 ***