After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723440 - ChatroomManager: don't use two simple clients
ChatroomManager: don't use two simple clients
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-02 00:16 UTC by Giovanni Campagna
Modified: 2014-05-08 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ChatroomManager: don't use two simple clients (3.57 KB, patch)
2014-02-02 00:16 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-02 00:16:55 UTC 
Requires gobject-introspection bug 723439 (and a telepathy-glib
built after that)
Comment 1 Giovanni Campagna 2014-02-02 00:16:57 UTC 
Created attachment 267814 [details] [review]
ChatroomManager: don't use two simple clients

What we want is one client that is both an observer and a handler.
We can't obtain that result with the simple classes, but we can
easily subclass TpBaseClient from gjs and implement both virtual functions.
This way, we only claim one name on the bus, and we only expose
one client path, which helps mission-control in routing messages
appropriately.
Comment 2 Volker Sobek (weld) 2014-03-22 13:39:07 UTC 
Would this perhaps fix bug 726875? (Haven't tested yet.)
Comment 3 Florian Müllner 2014-03-28 13:41:04 UTC 
Review of attachment 267814 [details] [review]:

OK.
Comment 4 Giovanni Campagna 2014-05-08 12:30:17 UTC 
Attachment 267814 [details] pushed as be9295f - ChatroomManager: don't use two simple clients