After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723439 - scanner: support virtual functions with a typedef-ed callback
scanner: support virtual functions with a typedef-ed callback
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-01 23:59 UTC by Giovanni Campagna
Modified: 2015-02-07 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: support virtual functions with a typedef-ed callback (20.86 KB, patch)
2014-02-01 23:59 UTC, Giovanni Campagna 		none Details | Review
scanner: support virtual functions with a typedef-ed callback (20.22 KB, patch)
2014-02-02 00:11 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-01 23:59:09 UTC 
The field of a callback need not be anonymous, it could be a
typedef, with a proper Type node.

Fixes TelepathyGlib.BaseClient having no virtual functions
(and probably others)
Comment 1 Giovanni Campagna 2014-02-01 23:59:11 UTC 
Created attachment 267812 [details] [review]
scanner: support virtual functions with a typedef-ed callback
Comment 2 Giovanni Campagna 2014-02-02 00:11:26 UTC 
Created attachment 267813 [details] [review]
scanner: support virtual functions with a typedef-ed callback

The field of a callback need not be anonymous, it could be a
typedef, with a proper Type node.

Fixes TelepathyGlib.BaseClient having no virtual functions
(and probably others)


This one's better...
Comment 3 Giovanni Campagna 2014-02-20 01:04:01 UTC 
Can I get a review here too? Thanks!
Comment 4 Colin Walters 2014-02-20 02:07:15 UTC 
Review of attachment 267813 [details] [review]:

Looks reasonable to me.
Comment 5 Giovanni Campagna 2014-02-20 02:23:49 UTC 
Attachment 267813 [details] pushed as b6568a4 - scanner: support virtual functions with a typedef-ed callback
Comment 6 André Klapper 2015-02-07 16:59:31 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]