GNOME Bugzilla – Bug 721673
Hide unsupported UI elements
Last modified: 2014-01-09 17:44:17 UTC
We should hide some elements from the Displays panel if we know they're not supported. For instance, Size and Rotation. The second patch depends on some new libgnome-desktop API from bug 721672.
Created attachment 265492 [details] [review] display: hide Size label when empty We currently just display an empty string next to the Size row if we can't compute that information. Hide it instead.
Created attachment 265493 [details] [review] display: show only rotation options if we support them Use the new libgnome-desktop API and determine if we can show or not rotation options.
Review of attachment 265493 [details] [review]: What about if upside-down is available but not 90 degrees rotations?
Review of attachment 265492 [details] [review]: Looks good to commit to master and gnome-3-10. Why is gnome_rr_output_get_physical_size failing though?
Comment on attachment 265492 [details] [review] display: hide Size label when empty Attachment 265492 [details] pushed as 53801be - display: hide Size label when empty
(In reply to comment #4) > Review of attachment 265492 [details] [review]: > > Looks good to commit to master and gnome-3-10. > > Why is gnome_rr_output_get_physical_size failing though? Thanks, I pushed this. It's not really failing - it just reports zero, and that value comes directly from mutter through Xorg. Buggy/incomplete display controller drivers... See also bug 721674 for a somewhat related fix.
Created attachment 265564 [details] [review] display: show only rotation options if we support them Use the new libgnome-desktop API and determine if we can show or not rotation options.
Review of attachment 265564 [details] [review]: Looks good.
Attachment 265564 [details] pushed as d0a832b - display: show only rotation options if we support them