After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721672 - gnome-rr: add API to check whether rotation is supported
gnome-rr: add API to check whether rotation is supported
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-07 03:10 UTC by Cosimo Cecchi
Modified: 2014-01-09 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-rr: add API to check whether rotation is supported (2.95 KB, patch)
2014-01-07 03:10 UTC, Cosimo Cecchi 		reviewed Details | Review
gnome-rr: add API to check whether rotation is supported (2.95 KB, patch)
2014-01-07 17:57 UTC, Cosimo Cecchi 		none Details | Review
gnome-rr: add API to check whether rotation is supported (2.97 KB, patch)
2014-01-07 18:00 UTC, Cosimo Cecchi 		committed Details | Review
build: bump version (764 bytes, patch)
2014-01-07 18:18 UTC, Cosimo Cecchi 		committed Details | Review
docs: update gnome-desktop3-sections.txt (3.79 KB, patch)
2014-01-07 18:18 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-01-07 03:10:41 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2014-01-07 03:10:42 UTC 
Created attachment 265491 [details] [review]
gnome-rr: add API to check whether rotation is supported

Export a method on GnomeRROutputInfo to check which rotation options are
supported.
Comment 2 Bastien Nocera 2014-01-07 07:07:03 UTC 
Review of attachment 265491 [details] [review]:

Looks fine otherwise. What about the wayland version?

::: libgnome-desktop/gnome-rr-private.h
@@ +63,3 @@
     int			y;
     GnomeRRRotation	rotation;
+    GnomeRRRotation	all_rotations;

available_rotations?
Comment 3 Cosimo Cecchi 2014-01-07 17:57:51 UTC 
Created attachment 265553 [details] [review]
gnome-rr: add API to check whether rotation is supported

Export a method on GnomeRROutputInfo to check which rotation options are
supported.
Comment 4 Cosimo Cecchi 2014-01-07 18:00:17 UTC 
Created attachment 265554 [details] [review]
gnome-rr: add API to check whether rotation is supported

--

Fixed the name of the variable. I don't think we need to do anything special here for Wayland - as far as I can see we're getting all the information from Mutter which already abstracts this for us. I haven't tested it on Wayland myself though.
Comment 5 Cosimo Cecchi 2014-01-07 18:18:05 UTC 
Created attachment 265556 [details] [review]
build: bump version

Since we added new API
Comment 6 Cosimo Cecchi 2014-01-07 18:18:09 UTC 
Created attachment 265557 [details] [review]
docs: update gnome-desktop3-sections.txt
Comment 7 Cosimo Cecchi 2014-01-09 17:42:46 UTC 
Attachment 265554 [details] pushed as 6040dbe - gnome-rr: add API to check whether rotation is supported
Attachment 265556 [details] pushed as 2b7b972 - build: bump version
Attachment 265557 [details] pushed as 1be326f - docs: update gnome-desktop3-sections.txt