GNOME Bugzilla – Bug 721674
monitor: improve heuristic to determine display output name
Last modified: 2014-01-09 11:43:48 UTC
This fixes some edge cases with the current display name heuristics.
Created attachment 265494 [details] [review] monitor: improve heuristic to determine display output name Under some circumstances, for example when the display controller driver doesn't report back the correct EDID, or under VirtualBox, Mutter returns suboptimal strings for an output display name, leading to funny labels like 'Unknown 0"', or '(null) 0"' in the Settings panel. This commit improves our heuristic in three ways: - we now avoid putting inches in the display name if either dimension is zero - we use the vendor name in case we're not able to lookup its PnP id from the database. Previously we would have passed over '(null)' - as a special edge-case, when neither inches nor vendor are known, we use the string 'Unknown Display' Finally, we make the combined vendor + inches string translatable, as different languages might want to move the size part of the string to a position different than the end.
Review of attachment 265494 [details] [review]: Looks good.
Attachment 265494 [details] pushed as 477acdd - monitor: improve heuristic to determine display output name Thanks, pushed to master.
Created attachment 265823 [details] [review] monitor: Suppress -Werror=unused-variable Broke the build for me.
Review of attachment 265823 [details] [review]: looks fine