Bug 696384 - Link suggestions UI issues
Link suggestions UI issues
Status: NEW
Product: gnome-contacts
Classification: Core
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
available
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-03-22 12:48 UTC by Andreas Nilsson
Modified: 2014-08-11 13:02 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Andreas Nilsson 2013-03-22 12:48:22 UTC 
Previously the "Does X belong here..." box had padding around it and rounded corners. Now it sticks to the sides of the view, but still have round corners and that makes it look bad.

Best is probably to remove the rounded corners.
Comment 1 Erick Perez Castellanos 2013-04-05 15:08:35 UTC 
Does this happens in 3.8 as well ?
Comment 2 Allan Day 2014-04-01 13:28:48 UTC 
The suggestion boxes don't seem to be working for me right now (bug 727435).
Comment 3 Allan Day 2014-04-08 11:57:54 UTC 
We can look at this now that bug 727435 is fixed. There are a number of UI issues with the link suggestions, including the one mentioned in the original report. I think it makes sense to deal with them together.

 1. Background has rounded corners.
 2. No top stroke (ie. border) on the box.
 3. Yes / No buttons are confusing - it doesn't actually say what will happen when you select yes.

For 1 & 2, I think it would be good to try using a GtkActionBar for the container.

For 3, we should replace the yes and no buttons with a "Link Contacts" button, and a close "X" button:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/contacts/png/selection.png
Comment 4 Erick Perez Castellanos 2014-08-11 13:02:07 UTC 
Work towards this on master.

Pushed here: https://git.gnome.org/browse/gnome-contacts/commit/?id=baafdaf29d682ca7f8d009e0d4091222b006cd4e
Note You need to log in before you can comment on or make changes to this bug.