After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688422 - message tray gets shifted up in the overview after expanding a notification
message tray gets shifted up in the overview after expanding a notification
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 688530 691880 692406 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-15 20:34 UTC by Sebastian Keller
Modified: 2013-01-23 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: don't accidentally shift the tray around in the overview (1.10 KB, patch)
2012-11-17 18:39 UTC, Sebastian Keller 		none Details | Review
messageTray: don't accidentally shift the tray around in the overview (1.29 KB, patch)
2012-11-18 00:21 UTC, Sebastian Keller 		none Details | Review
messageTray: don't accidentally shift the tray around in the overview (v3) (1.15 KB, patch)
2012-11-18 01:15 UTC, Sebastian Keller 		committed Details | Review

Description Sebastian Keller 2012-11-15 20:34:42 UTC 
to reproduce:
sleep 1; notify-send test "really looooooooooooooooooooooooooooooooooooooooooooooooooooong text"
go to the overview
move cursor onto the notification to expand it
wait for the notification to disappear

-> message tray has been shifted up by as much as the notification had to be shifted up to be fully expanded
Comment 1 Sebastian Keller 2012-11-17 18:39:48 UTC 
Created attachment 229249 [details] [review]
messageTray: don't accidentally shift the tray around in the overview

The problem I think is that _showTray() gets called when the actor is still the notification rather than the tray resulting in the shift.
But since I don't know the messageTray code well enough I'm not sure if the fix I have come up with is actually correct.
Comment 2 Allan Day 2012-11-17 19:07:55 UTC 
*** Bug 688530 has been marked as a duplicate of this bug. ***
Comment 3 Sebastian Keller 2012-11-18 00:21:41 UTC 
Created attachment 229259 [details] [review]
messageTray: don't accidentally shift the tray around in the overview

After looking at the code a bit more it seems that the summary is fading in and the old patch waited for this fading to be completed before moving the tray up. So instead of waiting for the summary to be completely shown - just use its height rather than using the entire actor, which at this point seems to still contain the notification.
Comment 4 Sebastian Keller 2012-11-18 01:15:17 UTC 
Created attachment 229262 [details] [review]
messageTray: don't accidentally shift the tray around in the overview (v3)

After applying the second patch I noticed that while the notification was still sliding out, the summary was already sliding in  - which didn't happen in the first patch because it would wait for the summary to completely fade in before sliding it up. Also ignoring other stuff that might have been stuffed into the tray might not be a good idea.
So this time just wait till the notification is completely hidden (not just hiding) and the actor should have the right height and the summary would only slide in after the notification is completely gone. No more overlapping animations and the summary is also fading in while it slides up as it was originally intended.
Comment 5 Giovanni Campagna 2012-11-20 00:02:54 UTC 
Review of attachment 229262 [details] [review]:

Uhm, makes sense, I guess
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-01-19 00:42:55 UTC 
*** Bug 691880 has been marked as a duplicate of this bug. ***
Comment 7 Andreas Nilsson 2013-01-23 18:15:00 UTC 
*** Bug 692406 has been marked as a duplicate of this bug. ***