After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685227 - shell-provider: adapt for new SearchProvider interface
shell-provider: adapt for new SearchProvider interface
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.12.x
Other All
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
available
: 728598 (view as bug list)
Depends on: 685224
Blocks: 699869
 
 
Reported: 2012-10-01 16:11 UTC by Cosimo Cecchi
Modified: 2014-09-23 16:17 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
shell-provider: adapt for new SearchProvider interface (950 bytes, patch)
2012-10-01 16:11 UTC, Cosimo Cecchi 		needs-work Details | Review
Patch for migrating to new GS search provider API (8.46 KB, patch)
2014-09-19 15:18 UTC, Erick Perez Castellanos 		reviewed Details | Review
Patch for migrating to new GS search provider API (8.44 KB, patch)
2014-09-19 15:52 UTC, Erick Perez Castellanos 		reviewed Details | Review
Patch for migrating to new GS search provider API (8.10 KB, patch)
2014-09-19 16:32 UTC, Erick Perez Castellanos 		committed Details | Review

Description Cosimo Cecchi 2012-10-01 16:11:47 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=685224
Comment 1 Cosimo Cecchi 2012-10-01 16:11:49 UTC 
Created attachment 225508 [details] [review]
shell-provider: adapt for new SearchProvider interface

It now has a timestamp argument to ActivateResult()
Comment 2 Alexander Larsson 2012-10-02 13:32:23 UTC 
Looks good to me. Feel free to push if the gnome-shell change lands.
Comment 3 Cosimo Cecchi 2012-12-06 20:58:05 UTC 
Review of attachment 225508 [details] [review]:

Needs work, since the API that has landed is different, to accomodate other shortcomings of the initial interface.
Comment 4 Matthias Clasen 2013-03-12 14:04:33 UTC 
given that contacts do show up in the search results, not a blocker
Comment 5 Erick Perez Castellanos 2014-09-19 15:16:24 UTC 
*** Bug 728598 has been marked as a duplicate of this bug. ***
Comment 6 Erick Perez Castellanos 2014-09-19 15:18:37 UTC 
Created attachment 286634 [details] [review]
Patch for migrating to new GS search provider API

This is approved by me, the maintainer :)
Comment 7 Erick Perez Castellanos 2014-09-19 15:52:52 UTC 
Created attachment 286644 [details] [review]
Patch for migrating to new GS search provider API

Same patch as before but cleaned a bit in order to avoid a string translation being need it
Comment 8 Erick Perez Castellanos 2014-09-19 16:32:54 UTC 
Created attachment 286645 [details] [review]
Patch for migrating to new GS search provider API

Same patch as before cleaned even more.
I've been removing not essential section in order to make breaking the lesser I can
Comment 9 Matthias Clasen 2014-09-19 20:51:17 UTC 
I've tested this too now, and it works
Comment 10 Erick Perez Castellanos 2014-09-19 21:04:41 UTC 
Review of attachment 286645 [details] [review]:

Good to go. Committed
Comment 11 Erick Perez Castellanos 2014-09-19 21:04:45 UTC 
Review of attachment 286645 [details] [review]:

Good to go. Committed
Comment 12 Erick Perez Castellanos 2014-09-19 21:06:01 UTC 
Fixed in master