After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685224 - search-provider: add a timestamp argument to ActivateResult()
search-provider: add a timestamp argument to ActivateResult()
Status: RESOLVED DUPLICATE of bug 689735
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 685225 685227 685228 685229
 
 
Reported: 2012-10-01 15:53 UTC by Cosimo Cecchi
Modified: 2012-12-06 20:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-provider: add a timestamp argument to ActivateResult() (5.48 KB, patch)
2012-10-01 15:53 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2012-10-01 15:53:00 UTC 
Currently the shell doesn't pass any user interaction timestamp down to the search providers, leading to some ugly code in the providers themselves, like [1].
Change the DBus interface of the search provider to include such an argument instead.
This will need changes in all the search providers; I will prepare patches and set them as dependent on this bug. Don't know if it's worth to try to get this in for 3.6.1, but it might be if we manage to patch all the providers at the same time.

[1] http://git.gnome.org/browse/nautilus/commit/?id=6bb4e031633df39859fc6d1652a319b6edd5b54f
Comment 1 Cosimo Cecchi 2012-10-01 15:53:02 UTC 
Created attachment 225504 [details] [review]
search-provider: add a timestamp argument to ActivateResult()

Since resutls are activated from user interaction from the provider
itself, we need to pass a timestamp down to the provider, so that it can
be passed to functions like gtk_show_uri().
Refactor all the activateResult() methods to have such a prototype -
some are currently different because of dragActivateResult(), which we
can completely handle, for those providers who support it, without
touching activateResult().
Comment 2 Cosimo Cecchi 2012-10-23 21:20:10 UTC 
Ping?
Comment 3 Cosimo Cecchi 2012-12-06 20:55:44 UTC 
This was solved as part of bug 689735.

*** This bug has been marked as a duplicate of bug 689735 ***