Created attachment 225510 [details] [review]
shell-provider: adapt for new SearchProvider interface

It now has a timestamp argument to ActivateResult()

Review of attachment 225510 [details] [review]:

The libgd change seems unrelated to this. The gnome-boxes-search-provider.vala looks good, let us know if this is 3.7 material only, or 3.6.1 as well (this seems to be undecided in the gnome-shell bug).

Created attachment 225513 [details] [review]
shell-provider: adapt for new SearchProvider interface

---

Yeah, the libgd change was here accidentally.

Review of attachment 225513 [details] [review]:

Needs work, since the API changed from this proposal to address other shortcomings of the old interface.

This has now landed in shell:
http://git.gnome.org/browse/gnome-shell/commit/?id=b390b82e9d66c01f8951b44ee6ef21c5d5be5d1e

Its opt-in, but we should proably support it.

Created attachment 234415 [details] [review]
Allow search with multiple terms

A search like "foo bar" now means name contains "foo" and "bar".
This is nicer, and what you expect from e.g. gnome-shell search.

Created attachment 234416 [details] [review]
Update to the new gnome-shell search interface

Note, these depend on the patches in Bug 692306

looks like the other bug is fixed, so maybe this can go in now ?

needs review

Review of attachment 234415 [details] [review]:

Looks good apart from a small nit. What will happen if someone runs this with a gnome-shell version using the old interface? Search will not work, but we won't get spectacular crashes I guess ?

::: src/collection.vala
@@ +31,2 @@
 private class Boxes.CollectionFilter: GLib.Object {
+    string [] terms;

Can you set visibility on that one? I guess vala defaults to private?

Review of attachment 234416 [details] [review]:

Looks good.

Review of attachment 234415 [details] [review]:

::: src/collection.vala
@@ +31,2 @@
 private class Boxes.CollectionFilter: GLib.Object {
+    string [] terms;

Yeah it does but we prefer explicit visibility

Review of attachment 234415 [details] [review]:

Should not crash, but you'll get some dbus error. I'll add an explicit visibility.

Attachment 234415 [details] pushed as 0628e99 - Allow search with multiple terms
Attachment 234416 [details] pushed as b9778a3 - Update to the new gnome-shell search interface