After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685229 - shell-provider: adapt for new SearchProvider interface
shell-provider: adapt for new SearchProvider interface
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: search
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on: 685224
Blocks: 686781
 
 
Reported: 2012-10-01 16:13 UTC by Cosimo Cecchi
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: 3.8
GNOME version: 3.7/3.8


Attachments
shell-provider: adapt for new SearchProvider interface (1.20 KB, patch)
2012-10-01 16:13 UTC, Cosimo Cecchi
reviewed Details | Review
shell-provider: adapt for new SearchProvider interface (972 bytes, patch)
2012-10-01 17:04 UTC, Cosimo Cecchi
needs-work Details | Review
Allow search with multiple terms (1.44 KB, patch)
2013-01-25 15:32 UTC, Alexander Larsson
committed Details | Review
Update to the new gnome-shell search interface (4.56 KB, patch)
2013-01-25 15:32 UTC, Alexander Larsson
committed Details | Review

Description Cosimo Cecchi 2012-10-01 16:13:48 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=685224
Comment 1 Cosimo Cecchi 2012-10-01 16:13:49 UTC
Created attachment 225510 [details] [review]
shell-provider: adapt for new SearchProvider interface

It now has a timestamp argument to ActivateResult()
Comment 2 Christophe Fergeau 2012-10-01 16:59:20 UTC
Review of attachment 225510 [details] [review]:

The libgd change seems unrelated to this. The gnome-boxes-search-provider.vala looks good, let us know if this is 3.7 material only, or 3.6.1 as well (this seems to be undecided in the gnome-shell bug).
Comment 3 Cosimo Cecchi 2012-10-01 17:04:23 UTC
Created attachment 225513 [details] [review]
shell-provider: adapt for new SearchProvider interface

---

Yeah, the libgd change was here accidentally.
Comment 4 Cosimo Cecchi 2012-12-06 20:56:50 UTC
Review of attachment 225513 [details] [review]:

Needs work, since the API changed from this proposal to address other shortcomings of the old interface.
Comment 5 Alexander Larsson 2013-01-11 11:11:26 UTC
This has now landed in shell:
http://git.gnome.org/browse/gnome-shell/commit/?id=b390b82e9d66c01f8951b44ee6ef21c5d5be5d1e

Its opt-in, but we should proably support it.
Comment 6 Alexander Larsson 2013-01-25 15:32:53 UTC
Created attachment 234415 [details] [review]
Allow search with multiple terms

A search like "foo bar" now means name contains "foo" and "bar".
This is nicer, and what you expect from e.g. gnome-shell search.
Comment 7 Alexander Larsson 2013-01-25 15:32:56 UTC
Created attachment 234416 [details] [review]
Update to the new gnome-shell search interface
Comment 8 Alexander Larsson 2013-01-25 15:35:32 UTC
Note, these depend on the patches in Bug 692306
Comment 9 Matthias Clasen 2013-02-03 16:33:02 UTC
looks like the other bug is fixed, so maybe this can go in now ?
Comment 10 Alexander Larsson 2013-02-04 08:39:59 UTC
needs review
Comment 11 Christophe Fergeau 2013-02-04 09:02:50 UTC
Review of attachment 234415 [details] [review]:

Looks good apart from a small nit. What will happen if someone runs this with a gnome-shell version using the old interface? Search will not work, but we won't get spectacular crashes I guess ?

::: src/collection.vala
@@ +31,2 @@
 private class Boxes.CollectionFilter: GLib.Object {
+    string [] terms;

Can you set visibility on that one? I guess vala defaults to private?
Comment 12 Christophe Fergeau 2013-02-04 09:09:37 UTC
Review of attachment 234416 [details] [review]:

Looks good.
Comment 13 Zeeshan Ali 2013-02-04 13:28:53 UTC
Review of attachment 234415 [details] [review]:

::: src/collection.vala
@@ +31,2 @@
 private class Boxes.CollectionFilter: GLib.Object {
+    string [] terms;

Yeah it does but we prefer explicit visibility
Comment 14 Alexander Larsson 2013-02-05 15:15:14 UTC
Review of attachment 234415 [details] [review]:

Should not crash, but you'll get some dbus error. I'll add an explicit visibility.
Comment 15 Alexander Larsson 2013-02-05 15:24:35 UTC
Attachment 234415 [details] pushed as 0628e99 - Allow search with multiple terms
Attachment 234416 [details] pushed as b9778a3 - Update to the new gnome-shell search interface