After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685198 - Duplicated partitions in the dashboard
Duplicated partitions in the dashboard
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
: 684085 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-01 10:43 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2012-10-03 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot before mounting (721.85 KB, image/png)
2012-10-01 10:43 UTC, Ignacio Casal Quinteiro (nacho) 		  Details
Check for duplicates before adding a volume (893 bytes, patch)
2012-10-01 22:00 UTC, Stefano Facchini 		committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2012-10-01 10:43:19 UTC 
Created attachment 225479 [details]
screenshot before mounting

I am experiencing several bugs here.

I get duplicated unmounted partitions reporting 0/0 size of usage. Once I click on it, it is mounted correctly and the scan starts.

Here there is another bug, in the scan it appears the (I guess temp folder name) in the root of the treeview instead of the display name of the partition.

Once it is mounted the size reported in the dashboard it looks correct. Although (in case it helps to debug) it just happens for the one I clicked on and not for the duplicated one.

Also say that these are windows partitions.
Comment 1 André Klapper 2012-10-01 11:31:15 UTC 
dup of bug 684085?
Comment 2 Stefano Facchini 2012-10-01 11:32:31 UTC 
(In reply to comment #0)
> Created an attachment (id=225479) [details]
> screenshot before mounting
> 
> I get duplicated unmounted partitions

Since duplicated entries appear after "Home folder", it seems to me that the only possibility is that for some reason the "volume-added" signal is triggered (the only place where we add unmounted locations). Maybe a bug in VolumeMonitor? but we could add some check for dups anyway.
Comment 3 Stefano Facchini 2012-10-01 18:38:25 UTC 
(In reply to comment #2)
> it seems to me that the
> only possibility is that for some reason the "volume-added" signal is triggered

It turns out that this is actually the case (see bug 684677) so we'll need a workaround for the 3.6 brach
Comment 4 Stefano Facchini 2012-10-01 19:13:22 UTC 
Pushed a fix for the "0/0 usage" issue, commit 5c7c0144b6740c3898cd030b2eae42697715c844
Comment 5 Stefano Facchini 2012-10-01 22:00:38 UTC 
Created attachment 225542 [details] [review]
Check for duplicates before adding a volume

So this is the porkaround, it can be committed after branching.
Comment 6 Stefano Facchini 2012-10-01 22:01:20 UTC 
*** Bug 684085 has been marked as a duplicate of this bug. ***
Comment 7 Paolo Borelli 2012-10-03 07:15:33 UTC 
Review of attachment 225542 [details] [review]:

Looks good, but let's add a comment with an explanation and a link to the gio bug
Comment 8 Stefano Facchini 2012-10-03 17:02:05 UTC 
Attachment 225542 [details] pushed as 8c87327 - Check for duplicates before adding a volume