GNOME Bugzilla – Bug 684677
drive-connected signal emitted on GVolumeMonitor creation
Last modified: 2012-09-25 14:46:53 UTC
The GProxyVolumeMonitor implementation in gvfs seems to unnecessarily emit *-added/*-connected signals when the object is created and a name owner for the remote volume monitor exists. This causes a minor annoyance in the shell, where the "device-added" sound is played when the shell starts up. Patch coming.
Created attachment 225032 [details] [review] proxy: don't emit connected/added signals at object creation It's unnecessary to emit those signals when the object is created, and it can cause weird side-effects if applications e.g. play a sound on signal emission.
Review of attachment 225032 [details] [review]: Seems to be working fine, patch makes sense. My only concern is a possible break of applications that depend on signals on startup. Let's push this to master, targetting Gnome 3.7 cycle and watch for breaks.
Attachment 225032 [details] pushed as ca7743a - proxy: don't emit connected/added signals at object creation Sounds good, thanks for the review!