After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683011 - Text tool discards text attributes in the on-canvas dialog and the text editor
Text tool discards text attributes in the on-canvas dialog and the text editor
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.8.2
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 675633 685448 686266 686449 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-30 01:01 UTC by tfinley44
Modified: 2012-11-09 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description tfinley44 2012-08-30 01:01:22 UTC
The text tool works fine with its default of 18 px text. Change 18 to any other figure or change to points (pt) and try to enter text. No matter what is done, the the tool reverts to the default settings, which are almost too small to be seen. Most users will not even know they are entering text.


      It may not be much of a problem, but it also seems impossible to move text down using the controls in the box.
Comment 1 Michael Natterer 2012-08-30 07:23:05 UTC
How exactly do you change the text size?
Comment 2 Shlomo D 2012-09-01 19:05:04 UTC
Duplicate of bug #675633

Reproduced on Linux with git master. Steps to reproduce:
1. Create a new image
2. Select the text tool. Click and drag in the image area to create a text area
3. Change to font size to 24px in the toolbar above the text area. (not in Tool Options)
4. Click the text area to gain focus and then type something
The tool reverts to the default font size (18px).

Changing the font size only takes effect on the selected (highlighted) text.
It has no effect when no text is selected.
This is counter-intuitive - it should be possible to select the font size before typing, rather than typing, selecting the entire text and then change it.
Comment 3 Chris 2012-10-15 20:32:40 UTC
Also overlaps with bug 682764
Comment 4 Max Mustermann 2012-10-17 18:56:04 UTC
*** Bug 686266 has been marked as a duplicate of this bug. ***
Comment 5 Max Mustermann 2012-10-17 19:16:24 UTC
The problem is more general: the font size field in the floating text dialog on the canvas depends on the the font size field in the dockable tool options dialog, but not vice versa. After step 3 in comment #2 the font size in the dockable dialog is still 18 px (the default). When clicking on the canvas again, the font size field in the on-canvas dialog gets and applies this value, discarding its former one.
To work around this you can set the font size in the dockable tool options dialog, not in the floating one on the canvas.  

Nevertheless the text attributes in the dockable tool options dialog should get updated after changing them in the on-canvas dialog.

The same is on Mac.
Comment 6 Max Mustermann 2012-10-19 10:09:03 UTC
*** Bug 686449 has been marked as a duplicate of this bug. ***
Comment 7 Michael Schumacher 2012-10-19 11:01:25 UTC
I think that even more of the recent bugs may be duplicates of this one.
Comment 8 Max Mustermann 2012-10-19 12:03:59 UTC
*** Bug 675633 has been marked as a duplicate of this bug. ***
Comment 9 Max Mustermann 2012-10-19 12:53:04 UTC
*** Bug 685448 has been marked as a duplicate of this bug. ***
Comment 10 Max Mustermann 2012-10-19 15:29:45 UTC
The same is with the Text editor, that pops up when clicking 'Use editor' in the Text tool options dialog.

I observed that strange behaviour with the following attributes: font size, font name, color. 
It also applies similarly to baseline and kerning. Both have no input fields in the Text tool options dialog. The values in the floating on-canvas dialog stay active as long as the user doesn't click into the text editor. After that they are reset to 0.0.
Comment 11 Michael Natterer 2012-11-09 21:37:55 UTC
Prerequisite for fixing this:

commit 2a77d536aaa4db9f7f1ce17a3a630fb1c2dc960f
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Nov 9 22:06:51 2012 +0100

    app: make Tab, Shift+Tab and Escape move the focus back to text editing
    
    when it was in the floating text style editor. While this doesn't fix
    anything by itself, it enables fixing text style setting to behave
    reasonably when there is no selection.
    (cherry picked from commit 76b05c2afcfb58c1cf00020d39cce23de91af6a5)
Comment 12 Michael Natterer 2012-11-09 22:32:17 UTC
Fixed in master and gimp-2-8, the other things mentioned here are
handled in other bugs.

commit 50c1e2d872346d06c27664b8cce18457e4faf87e
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Nov 9 23:05:04 2012 +0100

    Bug 683011 - Text tool discards text attributes in the on-canvas dialog...
    
    When font, size or color were changed, set the text buffer's current
    insert_tags just as we already do for the bold, italic etc. toggle
    buttons.  Changed gimp_text_style_editor_list_tags() to also return
    the tags for font, size or color.
    (cherry picked from commit abd2e78bdf47f157bcab13587c040d08c89a2fc1)

 app/widgets/gimptextbuffer.c      |    6 +--
 app/widgets/gimptextbuffer.h      |    6 +++
 app/widgets/gimptextstyleeditor.c |  142 ++++++++++++++++++++++++++++++++++++++-----------
 3 files changed, 119 insertions(+), 35 deletions(-)