After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677940 - [new roster] Individual manager: track more popular contacts
[new roster] Individual manager: track more popular contacts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 677429
Blocks: 669484
 
 
Reported: 2012-06-12 12:32 UTC by Guillaume Desmottes
Modified: 2012-06-18 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
individual-manager: keep track of most popular contacts (9.28 KB, patch)
2012-06-12 12:36 UTC, Guillaume Desmottes 		committed Details | Review
Revert "individual-manager: comment out interaction code" (2.38 KB, patch)
2012-06-14 09:31 UTC, Guillaume Desmottes 		committed Details | Review
individual-manager: document individual_notify_im_interaction_count() (1.18 KB, patch)
2012-06-14 09:31 UTC, Guillaume Desmottes 		committed Details | Review
individual-manager: document that individuals_pop ref its content (1.01 KB, patch)
2012-06-14 09:37 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-06-12 12:32:58 UTC 
Needed for bug #669484

This is blocked by a release and bump of Folks but can already be reviewed.
Comment 1 Guillaume Desmottes 2012-06-12 12:36:21 UTC 
Created attachment 216200 [details] [review]
individual-manager: keep track of most popular contacts
Comment 2 Guillaume Desmottes 2012-06-14 07:47:41 UTC 
Attachment 216200 [details] pushed as c85ceea - individual-manager: keep track of most popular contacts
Comment 3 Guillaume Desmottes 2012-06-14 08:03:20 UTC 
Shit I accidentally merged this with bug #677947.
I pushed 7f8fe5091b7a980133c0c3d1285cb718f8772142 commenting out the bits using Folks's new API.

I'll fix review comments in new commits and will revert this commit once Folks has been released.
Comment 4 Guillaume Desmottes 2012-06-14 09:31:02 UTC 
Created attachment 216395 [details] [review]
Revert "individual-manager: comment out interaction code"

This reverts commit 7f8fe5091b7a980133c0c3d1285cb718f8772142.
Comment 5 Guillaume Desmottes 2012-06-14 09:31:04 UTC 
Created attachment 216396 [details] [review]
individual-manager: document individual_notify_im_interaction_count()
Comment 6 Guillaume Desmottes 2012-06-14 09:37:21 UTC 
Created attachment 216397 [details] [review]
individual-manager: document that individuals_pop ref its content
Comment 7 Xavier Claessens 2012-06-18 09:29:41 UTC 
+1
Comment 8 Guillaume Desmottes 2012-06-18 09:30:11 UTC 
Attachment 216395 [details] pushed as 7a5547d - Revert "individual-manager: comment out interaction code"
Attachment 216396 [details] pushed as 35dfc34 - individual-manager: document individual_notify_im_interaction_count()
Attachment 216397 [details] pushed as 00a6f45 - individual-manager: document that individuals_pop ref its content