After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677429 - Release Folks 0.7.1
Release Folks 0.7.1
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal major
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 677940
 
 
Reported: 2012-06-05 04:27 UTC by Travis Reitter
Modified: 2012-06-15 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix release bugs on the way to 0.7.1. Squashed patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=release-0.7.1 (7.93 KB, patch)
2012-06-05 04:27 UTC, Travis Reitter
committed Details | Review

Description Travis Reitter 2012-06-05 04:27:03 UTC
Created attachment 215601 [details] [review]
Fix release bugs on the way to 0.7.1. Squashed patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=release-0.7.1

I spent today putting out a ton of little fires in the way of our next release. Unfortunately, bug #677428 is blocking us, and I'm way over-budget for my Folks time this week. So, I'm posting the work-in-progress here for someone else to pick up.
Comment 1 Jeremy Whiting 2012-06-12 20:54:24 UTC
Here make distcheck fails unless I enable all the backends.  Is that expected, or should distcheck be made to not worry about disabled backends (tracker in my current attempt)?
Comment 2 Philip Withnall 2012-06-13 01:42:27 UTC
(In reply to comment #1)
> Here make distcheck fails unless I enable all the backends.  Is that expected,
> or should distcheck be made to not worry about disabled backends (tracker in my
> current attempt)?

All backends have to be enabled for distcheck, or the C sources for those backends won’t be built (and thus won’t be in the tarball) iirc.
Comment 3 Travis Reitter 2012-06-13 21:24:18 UTC
You might also want to try adding all the --enable-*-backend flags, etc. in Makefile.am:DISTCHECK_CONFIGURE_FLAGS

I vaguely recall trying that and it failing though (which might explain why they're not already there), but that's really what we should be enforcing during a release distcheck.
Comment 4 Philip Withnall 2012-06-15 14:46:11 UTC
Comment on attachment 215601 [details] [review]
Fix release bugs on the way to 0.7.1. Squashed patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=release-0.7.1

Jeremy updated and committed all this.