After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677947 - [new roster] Add EmpathyRosterView
[new roster] Add EmpathyRosterView
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 669484
 
 
Reported: 2012-06-12 13:53 UTC by Guillaume Desmottes
Modified: 2012-06-14 07:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Guillaume Desmottes 2012-06-12 13:53:04 UTC
This is a good part of the implementation of bug #669484 but 'just' introduces the new widgets; it doesn't use them in the 'empathy' binary yet.
Comment 1 Guillaume Desmottes 2012-06-12 13:55:21 UTC
Patches are in http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=new-roster-view-only-677947

I tried to keep the patches as simple/atomic as possible, so it's probably a good idea to review the branch patch by patch.
Comment 2 Danielle Madeley 2012-06-14 03:23:23 UTC
+#define UNGROUPPED _("Ungroupped")

"Ungrouped"

~

Otherwise looks pretty good. No support for sorting by status anymore?
Comment 3 Guillaume Desmottes 2012-06-14 07:47:16 UTC
(In reply to comment #2)
> +#define UNGROUPPED _("Ungroupped")
> 
> "Ungrouped"

Fixed.
 
> Otherwise looks pretty good. No support for sorting by status anymore?

Nope, it's not part of the new design and I don't see it that useful tbh. We may  consider re-adding it if really needed.


Thanks a lot for the review.
Comment 4 Guillaume Desmottes 2012-06-14 07:48:14 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.