Created attachment 214995 [details] [review]
Remove compact mode

There is really little difference between compact mode and icon
mode with labels on the side. Well, except for that that horrible
horizontal scrolling.

Review of attachment 214995 [details] [review]:

Looks mostly good, I think it can go in with the following fixes

::: src/nautilus-file-management-properties.c
@@ -44,3 @@
 #define NAUTILUS_FILE_MANAGEMENT_PROPERTIES_DEFAULT_VIEW_WIDGET "default_view_combobox"
 #define NAUTILUS_FILE_MANAGEMENT_PROPERTIES_ICON_VIEW_ZOOM_WIDGET "icon_view_zoom_combobox"
-#define NAUTILUS_FILE_MANAGEMENT_PROPERTIES_COMPACT_VIEW_ZOOM_WIDGET "compact_view_zoom_combobox"

Can you also remove the define for the now unused NAUTILUS_FILE_MANAGEMENT_PROPERTIES_ALL_COLUMNS_SAME_WIDTH?

Also, the corresponding widgets (compact_view_zoom_combobox and all_columns_same_width_checkbutton) should be removed from nautilus-file-management-properties.ui

::: src/nautilus-icon-view-container.c
@@ +84,3 @@
 
+	flags = NAUTILUS_FILE_ICON_FLAGS_USE_MOUNT_ICON_AS_EMBLEM
+		| NAUTILUS_FILE_ICON_FLAGS_USE_THUMBNAILS;

The previous code is setting the USE_THUMBNAILS flag only for zoom_level > standard, which probably makes sense.

Created attachment 215001 [details] [review]
Remove compact mode

There is really little difference between compact mode and icon
mode with labels on the side. Well, except for that that horrible
horizontal scrolling.

Review of attachment 215001 [details] [review]:

Looks good now.

I'm not sure if I've understood correctly, but it seems to me we have an important difference between compact mode and icon with text beside icons. See attached screenshots. The horizontal scrolling is the price to pay to be able to read medium-long filenames easily for a human being, though it should be ellipsized at some point.

I'm not arguing about the upcoming changes at all, but the commit description suggest an alternative that does not seem to fit the use case of compact mode. 

Did somebody already used text beside labels in Nautilus? The wrapping makes it hard to visually scan for a file, see the last screenshot attached.

With your other changes, you talk about the latest design, where is it? I do not see anything yet on https://live.gnome.org/Design/Apps/Files. Or is it http://gitorious.org/gnome-design ones?

Created attachment 215031 [details]
Nautilus compact view (not the most representative filenames for sure)

Created attachment 215032 [details]
Nautilus icon view with labels on sides

Created attachment 215033 [details]
The broken label wrapping and cropping of label by sides mode

Well, maybe I'm worried because the label on sides feature is not very useful most of the time, so a solution would be to just fix it once for all, even if laying out this kind of container must be really hard when taking all scenarios in account.

no they are not the same .... specialy with files with long names ???
people actualy use it !!! why to remove it !!
at least give the user a choice !! and why gnome people are taking very bad decisions these days
which mode has to be removed !!! 
this 
http://img844.imageshack.us/img844/4128/screenshotfrom201206200.png
or 
this 
http://img24.imageshack.us/img24/4128/screenshotfrom201206200.png

why not to fix horizontal scrolling by just make compact view only use one column and all files are listed in one column

@amr the list mode shows a sort-of one-column layout you suggest. IMHO, the advantage of the compact mode is to list all their files with the complete names in a reduced space.

this kinda sucks that instead of fixing it it's being removed.

makes my old bug irrelevant.
https://bugzilla.gnome.org/show_bug.cgi?id=585511

without compact view icon view needs:
horizontal scrolling
better text wrapping for large filenames
disable all columns have the same width

I'm sure most of us will get used to it but the text wrapping in 3.4.2 (unless it's changed in 3.5.x) is just as annoying as a broken compact view.

William, your presumtions about the compact view are that:
a) a horizontal scrollbar is horrible - why is that?
b) it can be replaced by the icon view with labels on the right.

I think that screenshots attached by amr and stephane clearly invalidate the second point.

> The compact mode does horrible things

Sorry but this is a very bad joke. What's GNOME's goal beyond alienating users and forcing them to find alternative software? What a bullshit.

https://live.gnome.org/CodeOfConduct says for a reason: 
"If you disagree, please do so politely."
Please go to random forums on the internet instead - there you can add your unhelpful comments that might make developers not want to look at certain bug reports anymore.

Review of attachment 215001 [details] [review]:

Why would you remove this? It's clearly not the same at all as icon mode with labels.
It's far harder to search through and is just plain ugly in comparison.

This, along with all the other incredibly important features being removed is pushing me away from nautilus. Please revert this decision.

I have used the compact view or its equivalent in various file managers for about twenty years now.  It is my default view (set to 50%) in nautilus, the first thing I set up when I put in a new install.  Single width, truncated filenames solve much of the problematic behavior of the compact view dealing with long file names, and the filename if you need to verify the whole thing, pops up in full on mouseover and in the (now floating) status bar when highlighted, solving the truncation problem for me.  

Horizontal scrolling makes it easier to scan a long list of alphabetical or otherwise organized files by looking at the top in each column to see if the column contains the file name rather than scanning through every filename in a single column or scrolling through an un-intuitive LR, Top to Bottom icon view. While horizontal scrolling is poor with a traditional mouse, touchpads and multitouch do great with it.  It is by far the fastest most efficient way to scan through a directory when for example, you can't remember the exact filename.  

I understand and am resigned to the certain knowledge that it is better to do it the way designers say I should rather than how I have been doing it for twenty years, so it looks like I'll look for another file manager and then have to give up other things, like dropbox support, that I have come to expect in my file manager.  

remove another user ...  done.

Horizontal scrolling might bother some, but with recent multitouch trackpads, it works great. And even with a regular mouse, the scrollwheel works just fine.

Compact mode in nautilus is very important for me and after reading this thread, for a lot of people. Screenshots have already been presented to prove that compact mode is definitely not the same as icons with labels on the side. Removal of this mode will definitely force me to find alternatives.

And what's the benefit of removing this mode?

- It's definitely not duplicating any existing features.
- It's not like nobody uses it either. Many people use it.
- Few kB of code removed and few bytes of binary file size reduction? Is it really worth removing it? It's not trash/junk, it's a useful feature. It should not be thrown out.

Might I suggest to simply implement vertical scrolling in the Compact View?

Now that you removed my favorite view mode, are you willing to shed some light on how do I accomplish the "labels on the side" thing? There seems to be no option for this?

And why do you think horizontal scrolling is horrible? rcrath@yahoo.com has a good point. Moreover, horizontal scrolling seems smoother to me, perhaps because icons here don't move so fast like in list view but.

For me, scroll button of mouse works same for horizontal as well as vertical scrolls.

I've made a separate bug report for restoring Compact View: Bug 695438

Not much to add, comments #13, #14, #16, #17, #18, #19, #20, #21, #22, #23 has told enough.

As "fix" was committed almost a year ago and no situation rollback since that, it's unlikely that "Compact mode" will come back... So, we have a wide choice: patch, fork (both are already available, of course) or another product. Or, who knows, maybe Canonical will create its own file-manager, as a companion to Unity. X)

(In reply to comment #15)
> https://live.gnome.org/CodeOfConduct says for a reason: 
> "If you disagree, please do so politely."

Good point. Developers that filed and "fixed" this bug surely did so. They've created poll, just to be sure they don't broke workflow some of that millions users.

> Please go to random forums on the internet instead - there you can add your
> unhelpful comments that might make developers not want to look at certain bug
> reports anymore.

I would be happy if developers with such ideas and methods go to maintain some other projects, much less widespread.

Hmm... I just figured that it's the first unfriendly comment from me in OSS industry for more than twenty years of development.

The removal of compact mode is a terrible regression, NOT a feature. I was very disappointed to see it go... and I hope the devs correct this mistake in the future.

For me, this is not "resolved fixed". It is "resolved to remain a regression", which is much more depressing.