After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662811 - "Log Out..." item in user menu should not include an ellipsis.
"Log Out..." item in user menu should not include an ellipsis.
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other All
: Normal trivial
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-26 22:21 UTC by Greg K Nicholson
Modified: 2012-05-11 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (531 bytes, patch)
2011-11-03 17:41 UTC, Ritesh Khadgaray ( irc:ritz)
needs-work Details | Review
Patch changing the strings in the user menu. (2.30 KB, patch)
2012-04-11 02:13 UTC, Gabriel Poesia
none Details | Review

Description Greg K Nicholson 2011-10-26 22:21:28 UTC
The latest version of the Gnome HIG, § 4.3.2.1 <http://developer.gnome.org/hig-book/3.2/menus-design.html.en#menu-item-type-command> says:

“
Label the menu item with a trailing ellipsis ("...") only if the command requires further input from the user before it can be performed. Do not add an ellipsis to items that only present a confirmation dialog (such as Delete), or that do not require further input (such as Properties, Preferences or About).
”

"Log Out..." only presents a confirmation dialogue: the only options are "Log Out" and "Cancel". According to the HIG, the menu item shouldn't include an ellipsis.

(Moreover, the user is logged out automatically after 60 seconds; so even if it was correct to use an ellipsis to signify that confirmation is required, it still wouldn't be correct to use an ellipsis in this case.)
Comment 1 Milan Bouchet-Valat 2011-10-27 08:49:57 UTC
Would you provide the patch? ;-)
Comment 2 Ritesh Khadgaray ( irc:ritz) 2011-11-03 17:41:45 UTC
Created attachment 200622 [details] [review]
patch
Comment 3 Owen Taylor 2012-01-24 21:43:05 UTC
Review of attachment 200622 [details] [review]:

Thanks for the patch! Please see https://live.gnome.org/GnomeShell/Development/WorkingWithPatches for how to attach a patch formatted with a commit message
Comment 4 Gabriel Poesia 2012-04-11 02:13:42 UTC
Created attachment 211802 [details] [review]
Patch changing the strings in the user menu.

A patch for this (also changing "Power off..." to "Power off", as the further input it requires is of the same type).
Comment 5 Milan Bouchet-Valat 2012-05-11 13:51:02 UTC
This has been fixed by attachment 213809 [details] [review] from bug 675802. Sorry for the terrible delay!