GNOME Bugzilla – Bug 653996
[UI] Use GtkOverlay for the status bar
Last modified: 2011-12-14 15:05:48 UTC
Use GTK's overlay implementation instead of the version imported from Gedit.
Created attachment 191281 [details] [review] [UI] Use GtkOverlay for the status bar Use the recently introduced GtkOverlay widget for our floating status bar. This remove the need to use the imported GeditOverlay. Thus removing the related files.
Created attachment 191283 [details] [review] [UI] Use GtkOverlay for the status bar Use the recently introduced GtkOverlay widget for our floating status bar. This remove the need to use the imported GeditOverlay. Thus removing the related files. Fix overfluous newline.
Review of attachment 191283 [details] [review]: Does this still do the escaping-from-mouse thing? I don't seem to find that part of the magic. ::: embed/ephy-embed.c @@ -44,3 @@ #include "ephy-web-view.h" -#include "gedit-overlay.h" -#include "ephy-overlay-escaping-child.h" Did you forget to git rm ephy-overlay-escaping-child.h? ::: lib/widgets/Makefile.am @@ -25,3 @@ - gedit-overlay-child.h \ - ephy-overlay-escaping-child.c \ - ephy-overlay-escaping-child.h git rm the ephy-overlay ones!
Created attachment 202760 [details] [review] Use a GtkOverlay for the statusbar instead of shipping GeditOverlay Instead of escaping the cursor, we align the overlay at the opposite side of the window. This is consistent with nautilus.
Review of attachment 202760 [details] [review]: I really prefer the current behavior, but I'm OK with committing this not to not block future work. But please let's go back to the design team and propose to keep things as we have them. ::: embed/ephy-embed.c @@ +519,3 @@ + gtk_widget_set_halign (widget, GTK_ALIGN_START); + } + No braces for one line clauses, and indentation seems to be off.
Comment on attachment 202760 [details] [review] Use a GtkOverlay for the statusbar instead of shipping GeditOverlay I need to fix this first... Gtk-CRITICAL **: gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -9 and height -9 Gtk-CRITICAL **: gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -9 and height -9 Gtk-CRITICAL **: gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -9 and height -9 Gtk-CRITICAL **: gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -9 and height -9
That was a GTK+ bug. Fixed in bug 666109.
Comment on attachment 191283 [details] [review] [UI] Use GtkOverlay for the status bar Changed status in the wrong patch. Blame git bz.