After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654007 - Use GtkStatusBar for status display
Use GtkStatusBar for status display
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 653996
Blocks: 654163
 
 
Reported: 2011-07-05 13:51 UTC by Alexandre Mazari
Modified: 2012-01-16 23:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GtkStatusBar for status display (9.02 KB, patch)
2011-07-05 13:51 UTC, Alexandre Mazari 		none Details | Review
Use GtkStatusBar for status display (9.02 KB, patch)
2011-07-05 13:58 UTC, Alexandre Mazari 		none Details | Review
Use GtkStatusBar for status display (9.20 KB, patch)
2011-07-07 15:04 UTC, Alexandre Mazari 		none Details | Review

Description Alexandre Mazari 2011-07-05 13:51:52 UTC 
Use a GtkStatusbar in the overlay uinstead of our custom frame+label.
Status queue code imported from gtk could then be removed.
This prepare the introduction of an 'escaping' GtkStatusBar subclass.
Comment 1 Alexandre Mazari 2011-07-05 13:51:55 UTC 
Created attachment 191317 [details] [review]
Use GtkStatusBar for status display

Replace our custom status widget in the overlay by GtkStatusBar.
Status queue code copied from Gtk could then be removed.
This prepares the introduction of a 'sliding' GtkStatusBar subclass.
Comment 2 Alexandre Mazari 2011-07-05 13:58:00 UTC 
Created attachment 191321 [details] [review]
Use GtkStatusBar for status display

Replace our custom status widget in the overlay by GtkStatusBar.
Status queue code copied from Gtk could then be removed.
This prepares the introduction of a 'sliding' GtkStatusBar subclass.

Fix whitespaces
Comment 3 Xan Lopez 2011-07-06 16:21:19 UTC 
I'm not really sure about this. It means to use a widget in a completely different way than it's usually used just because you are interested in some aspect of its behavior (namely the stack-like message API). I think copying that code to our thing makes sense, since our widget really is pretty different.
Comment 4 Alexandre Mazari 2011-07-07 15:04:39 UTC 
Created attachment 191467 [details] [review]
Use GtkStatusBar for status display

Replace our custom status widget in the overlay by GtkStatusBar.
Status queue code copied from Gtk could then be removed.
This prepares the introduction of a 'sliding' GtkStatusBar subclass.

Updated:
- remove unused method
Comment 5 Alexandre Mazari 2011-07-08 09:13:42 UTC 
(In reply to comment #3)
> I'm not really sure about this. It means to use a widget in a completely
> different way than it's usually used just because you are interested in some
> aspect of its behavior (namely the stack-like message API). I think copying
> that code to our thing makes sense, since our widget really is pretty
> different.

GtkStatusbar is a nice fit to, well... display a status bar.
Looking at its source, it is not much more complex than using our GtkFrame->GtkLabel + copying the queue code.
The hierarchy is a bit deeper with GtkBox->Frame->GtkBox->GtkLabel.

Pragmaticaly, The end result being less code duplication and less code to maintain for the exact same result. What's not to love about it ? :)

Thanks for your review !
Comment 6 Xan Lopez 2012-01-16 23:53:39 UTC 
We are sharing NautilusFloatingBar with Nautilus now, so I guess this is obsolete. Thanks for the patch though!