After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648600 - Video files are being identified as music, causing removal on sync
Video files are being identified as music, causing removal on sync
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Device - iPod
2.0.0
Other Linux
: Normal major
: 1.x
Assigned To: Alan McGovern
Banshee Maintainers
gnome[unmaintained]
: 632513 (view as bug list)
Depends on: 655660
Blocks:
 
 
Reported: 2011-04-25 11:30 UTC by Age Bosma (IRC: Forage)
Modified: 2020-03-17 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Debug log (9.37 KB, text/plain)
2011-04-26 16:45 UTC, Age Bosma (IRC: Forage)
Details
Ouput of udevadm info --export-db (124.74 KB, text/plain)
2011-04-26 17:49 UTC, Age Bosma (IRC: Forage)
Details
Output of gvfs-mount --list (444 bytes, text/plain)
2011-04-26 17:49 UTC, Age Bosma (IRC: Forage)
Details

Description Age Bosma (IRC: Forage) 2011-04-25 11:30:39 UTC
All video files (at least .mp4 and .m4v) are identified as music files when the iPod (6th gen) is loaded. The fact that video files are considered music can be determined by the music part size in the graph. The files graph does not display a video part (green), only music (blue) and other (orange). The size of the music part is the size of the music collection plus the size of all added videos.
The video files are, however, not showing up in the library list of the device.

The result of this behaviour is that Banshee insists on removing the video files when syncing the device library with your music collection. When you don't agree with the removal, Banshee will not continue to sync (which is a different issue I'll file). When you do agree, you'll have to re-add all video files again afterwards.

I should add that I add the video files by using GTKPod instead of Banshee, but this didn't cause problems with Banshee 1.8.x.
Comment 1 David Nielsen 2011-04-26 15:40:48 UTC
Can you please obtain a Debug log showing this issue?

https://live.gnome.org/Banshee/CommonQuestions/Logs
Comment 2 Age Bosma (IRC: Forage) 2011-04-26 16:45:09 UTC
Created attachment 186668 [details]
Debug log

Of course! I should be making a habit of it, I know, sorry.

Attached you'll find the debug log, including the following:
- Launch of Banshee with iPod already attached.
- Loading of iPod
- Hitting the sync option
- Cancelling the action when notified about the removal of the files (video) not included in the library

Let me know if you need any more information.
Comment 3 David Nielsen 2011-04-26 17:21:05 UTC
This doesn't look encouraging:

** (Banshee:3523): CRITICAL **: itdb_splr_validate: assertion `at != ITDB_SPLAT_UNKNOWN' failed

For completeness can you provide the information requested in the "Filing bugs" section steps 3 to 5 as well?

https://live.gnome.org/Banshee/LibgpodTransition
Comment 4 Age Bosma (IRC: Forage) 2011-04-26 17:48:40 UTC
Do note that the error you mention does not occur until I start syncing the device. The iPod has already been completely loaded before "[4 Debug 18:40:58.221] Starting AppleDevice sync thread cycle".

Device information:
- iPod Classic (6th generation), black, 160GB
- Firmware: 2.0.4
- Serial: ........9ZU

No clue where the part/model code should be obtained from. In which program should I be looking in the "About" section for this?

Log files are coming up next.
Comment 5 Age Bosma (IRC: Forage) 2011-04-26 17:49:22 UTC
Created attachment 186675 [details]
Ouput of udevadm info --export-db
Comment 6 Age Bosma (IRC: Forage) 2011-04-26 17:49:55 UTC
Created attachment 186676 [details]
Output of gvfs-mount --list
Comment 7 Age Bosma (IRC: Forage) 2011-04-26 19:05:37 UTC
I've managed to find to cause of the issue. The changes made to fix bug 636448 caused files determined to be of the type AudioVideo by libgpod to be ignored as being a VideoStream therefore defaulting to AudioStream.

I should also note that the comment made by Shane in bug 636448 that m4a files are also listed under movies for his iPod classic is not the case for me.
Reverting the commit made for that bug places all movies correctly under movies and m4a files correctly under music.
Comment 8 David Nielsen 2011-04-27 03:50:33 UTC
I suspect the following post 2.0 commit might address the issue. You can test it either using the Daily PPA or the 2.0.1 release which should hit the Maintained release PPA in a couple of days.

http://git.gnome.org/browse/banshee/commit/?id=8cadf85c1790c01c6124b21ea8c7b2d8cbc9b59f

https://live.gnome.org/Banshee/CommonQuestions/TestingOnUbuntu
Comment 9 Age Bosma (IRC: Forage) 2011-04-27 07:04:50 UTC
No, it will not address the issue. I've tested the latest source before digging into the code. It wasn't until I reverted the mentioned commit that it started working again.

I fear that the commit you are referring to might even make matters worse since it includes only audio mime types, no video mime types like "taglib/mp4".
Comment 10 Chow Loong Jin 2011-06-28 11:53:19 UTC
Just for the record, https://bugs.launchpad.net/ubuntu/+source/libgpod/+bug/772089 is the bug in Ubuntu, and is fixed in natty-proposed and oneiric. The natty-proposed one requires testing.
Comment 11 Andrés G. Aragoneses (IRC: knocte) 2011-06-28 12:14:38 UTC
Chow, thanks for that info. See inline:

(In reply to comment #10)
> Just for the record,
> https://bugs.launchpad.net/ubuntu/+source/libgpod/+bug/772089 is the bug in
> Ubuntu, and is fixed in natty-proposed and oneiric. The natty-proposed one
> requires testing.

By pointing to a libgpod bug, are you telling us that the fix was in libgpod? If yes, can you tell us the version of libgpod that oneiric has?

Age Bosma (reporter) or other affected users: can you tell us the version of libgpod you have currently?

Thanks in advance.
Comment 12 Chow Loong Jin 2011-06-28 12:19:37 UTC
Yes, the affected package is libgpod, and the fix for this is specifically the commit 9a64ee60dd3e68c78292b97241616ac1d7a01c15[1]. The fixed libgpod packages in Debian and Ubuntu are 0.8.0-3, and 0.8.0-2ubuntu0.1, which have the patch cherry-picked in.

There hasn't been a libgpod release from upstream that includes this fix. 

[1] http://gtkpod.git.sourceforge.net/git/gitweb.cgi?p=gtkpod/libgpod;a=commit;h=9a64ee60dd3e68c78292b97241616ac1d7a01c15
Comment 13 Andrés G. Aragoneses (IRC: knocte) 2011-06-28 12:23:44 UTC
(In reply to comment #12)
> Yes, the affected package is libgpod, and the fix for this is specifically the
> commit 9a64ee60dd3e68c78292b97241616ac1d7a01c15[1]. The fixed libgpod packages
> in Debian and Ubuntu are 0.8.0-3, and 0.8.0-2ubuntu0.1, which have the patch
> cherry-picked in.

Thanks for the info!

> There hasn't been a libgpod release from upstream that includes this fix.

Ok, I'm adding teuf to CC to see if he can make a release. Ideally we would switch Banshee to require this release for the next version, so we can close this as FIXED.
Comment 14 Age Bosma (IRC: Forage) 2011-06-28 13:18:18 UTC
Thank for the heads-up Chow.

I currently have version 0.8.0-2 of libgpod4 installed since I'm running Ubuntu Natty.

I do, however, have my doubts that the fixes for libgpod will fix this issue as well. Unless, of course, the changes to libgpod4 will cause the same files to be identified as type 'Movie'.
Due to the commit for bug #636448 [1] type 'VideoStream' files are specifically ignored when loading the iPod. If I undo these changes the issue is gone.

When the new version of libgpod4 comes available in the next few hours I will test if it resolves anything and let you know.


[1] http://git.gnome.org/browse/banshee/commit/src/Dap/Banshee.Dap.AppleDevice/Banshee.Dap.AppleDevice/AppleDeviceTrackInfo.cs?id=35671996b8f9ea69cd081d88b6f2e1603a839ab9
Comment 15 Chow Loong Jin 2011-06-28 14:50:48 UTC
I forgot to mention -- libgpod is an "unstable" library, so the dlls found inside the library are copied into the Banshee package during compile-time.

In other words, the version of libgpod4 is not what you should be looking at, but the version of Banshee.

The fixed versions of Banshee in Oneiric and Natty-proposed are 2.1.0-1ubuntu3 and 2.0.0-2ubuntu2 respectively.
Comment 16 Age Bosma (IRC: Forage) 2011-07-03 14:34:15 UTC
Well I'll be damned...

In version 2.0.0-2ubuntu2 the issue is fixed! I guess I owe you guys an apology for my distrust in this issue being fixed.

Sorry for the delay by the way. Version 2.0.0-2ubuntu2 never showed up as an upgrade in natty-proposed. After a few days waiting I started looking more closer and the reason was simple. I had version 2.0.1 installed from the Banshee PPA...

Would it also be possible to recompile 2.0.1 in ppa:banshee-team/ppa? I had to downgrade now, which would be a shame.

Many thanks for the fix. Now I can finally stop working manually.
Comment 17 Chow Loong Jin 2011-07-03 18:34:04 UTC
Yeah I'll do that. Looks like I forgot to upload the libgpod fix there.
Comment 18 Age Bosma (IRC: Forage) 2011-07-04 11:55:28 UTC
Version 2.0.1 works like a charm now as well, thank you.
Comment 19 Andrés G. Aragoneses (IRC: knocte) 2011-08-16 10:15:11 UTC
Akhil, the fix is not upstream.
Comment 20 Andrés G. Aragoneses (IRC: knocte) 2011-08-16 12:16:07 UTC
*** Bug 632513 has been marked as a duplicate of this bug. ***
Comment 21 André Klapper 2020-03-17 09:28:07 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.