GNOME Bugzilla – Bug 655660
Banshee does not build against installed libgpod-sharp
Last modified: 2020-03-17 09:21:14 UTC
Created attachment 192930 [details] [review] uint casting patch When building on openSUSE 11.4 with libgpod-sharp installed from obs://build.opensuse.org/Banshee, ver. 0.8.2-30.1. ./Banshee.Dap.AppleDevice/AppleDeviceTrackInfo.cs(218,24): error CS0266: Cannot implicitly convert type `int' to `uint'. An explicit conversion exists (are you missing a cast?) attached patch fixes cast problem.
Created attachment 192933 [details] [review] format-patch version
Do we even need the cast?
Yes, because filesize is stored as a long.
*** Bug 657304 has been marked as a duplicate of this bug. ***
*** Bug 661947 has been marked as a duplicate of this bug. ***
Age: do you mind reviewing this 1-liner patch. I'm just concerned that committing the patch may cause Banshee not compile with previous versions of libgpod. If this is the case, we should maybe just raise the version of libgpod-sharp required in the configuration phase, although not sure how far did you get about having a proper version information in libgpod-sharp pc file. Can you update us? Thanks
Sorry for replying to myself! (In reply to comment #6) > Age: do you mind reviewing this 1-liner patch. > > I'm just concerned that committing the patch may cause Banshee not compile with > previous versions of libgpod. Mmmh, well just realised that a cast like this wouldn't do any harm I guess (when compiling against previous versions, the cast would just be redundant, but would not cause warnings or errors). Anyway the input of Forage (Age) is always appreciated before doing anything here.
With the patch, banshee does not build anymore against libgpod-sharp 0.8.0: ./Banshee.Dap.AppleDevice/AppleDeviceTrackInfo.cs(218,24): error CS0266: Cannot implicitly convert type `uint' to `int'. An explicit conversion exists (are you missing a cast?) You cannot check using pkg-config for the right version of libgpod-sharp, as it is at 0.1 in both libgpod 0.8.0 and 0.8.2, but you can check for the version of libgpod.
@knocte: I provided several patches for libgpod, including the version issue, but unfortunately all of them still need a review. Teuf is the one to do this but he is unable to find the time to do it. Maybe he'll become more motivated if you ask him about it as well ;-)
> Christophe Fergeau <teuf> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |teuf@gnome.org Hey Christophe, welcome! As you see, we're having problems to link to different versions of libgpod. Right now banshee only compiles against an old one. If we change banshee to fix the cast, it will get fixed only for the new version of libgpod-sharp, but it would stop compiling against the old version (thanks for the clarification Götz). So we need some kind of version-check at the configuration phase to detect the version of libgpod-sharp in order to have #if clauses in our C# code, or just to stop supporting old versions of libgpod. For that, I believe Forage has contributed a patch to bring the correct version to libgpod-sharp .pc file, can you review it when you have time? Thanks!
Note: Fedora 16 has the new version of libgpod, so is effected by this bug.
*** Bug 666743 has been marked as a duplicate of this bug. ***
Created attachment 207359 [details] [review] Patch to check for libgpod-sharp 0.8.2 and change the cast appropriately This patch unfortunately doesn't work against libgpod 0.8.2 because Version of libgpod-sharp.pc was hardcoded to 0.1. This will require a patch to libgpod which I will also attach to this bug shortly.
Created attachment 207360 [details] [review] Patch to set Version appropriately in libgpod-sharp.pc
I've provided a libgpod patch for the versioning issue quite some time ago [1]. A different, but imho better, solution then this one (see comments). Unfortunately it still has to get applied. [1] http://sourceforge.net/tracker/?func=detail&atid=519275&aid=3398055&group_id=67873
*** Bug 669874 has been marked as a duplicate of this bug. ***
Comment on attachment 192933 [details] [review] format-patch version This patch is obsoleted by Age's patch.
*** Bug 671284 has been marked as a duplicate of this bug. ***
FYI, I've just committed the following patch, so that git master builds against libgpod-sharp 0.8.2: http://git.gnome.org/browse/banshee/commit/?id=623695e5 This is only going to git master and the upcoming 2.5.X releases. As mentioned in the commit message, people shipping those should really be also shipping the libgpod-sharp 0.8.2. I'm keeping this bug open, as we still want to detect the libgpod-sharp version when the next release allows it.
*** Bug 679572 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.