GNOME Bugzilla – Bug 635513
Message displayed TWICE (in chat msg overlay) when opening a chat window for unread msg
Last modified: 2011-08-29 10:12:43 UTC
I'm using Empathy 2.32.0.1 that comes bundled with Ubuntu 10.10 To replicate the issue, do the following: * Ask a friend to IM you. * Unread IM notification is shown in the notification applet. Simultaneously, a black bubble-like overlay is shown in the top-right corner with the IM text. * Click on the notification applet to open the IM chat window. * The black bubble shows the IM text _again_ right below the original text. This looks as if the IM msg is repeated twice. This does not happen if the chat window (with that particular buddy) is already open. PS: I cannot find the right technical term for "black bubble", so pardon my layman terms! :)
I can't reproduce this issue. What happen exactly? The first bubble disappears and then a new one re-appear once you click on the status icon? Or is the bubble stay displayed and is extended to display the same msg twice ?
The second scenario happens i.e "the bubble stay displayed and is extended to display the same msg twice" I was able to reproduce it in another machine as well. Basically you have to open the chat window and then you 'll see the msg come twice in the overlay bubble. If the chat window (with that buddy) was already open, it does NOT happen. Let me know if you need more info. Thanks, -mandeep
I can't reproduce this. Could you please start "dbus-monitor" before receiving the msg, reproduce the bug and then attach its log?
Created attachment 175148 [details] IM msg arrives for the firt time.
Created attachment 175149 [details] Clicking on notification applet
Created attachment 175150 [details] DBUS monitor log dbus-monitor was run _before_ receiving the IM message. I stopped it _after_ opening the IM chat window by clicking on the notification applet. Let me know if you need more info.
Indeed Notify() is called twice. Do you have the "Enable notifications when the chat is not focused" on ?
Yes, I have "Enable notifications when the chat is not focused" checked.
Does it still happen if you uncheck it?
No, it does not happen if I uncheck it. But then I won't get notifications in case the chat window is not in focus.
Created attachment 175532 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/msg-notif-635513 libempathy-gtk/empathy-chat.c | 16 ++++++++++------ src/empathy-chat-window.c | 7 ++++++- 2 files changed, 16 insertions(+), 7 deletions(-)
Comment on attachment 175532 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/msg-notif-635513 > #include <libempathy/empathy-debug.h> > >+ > #define CHAT_DIR_CREATE_MODE (S_IRUSR | S_IWUSR | S_IXUSR) That seems unnecessary > static void > chat_window_new_message_cb (EmpathyChat *chat, > EmpathyMessage *message, >+ gboolean pending, > EmpathyChatWindow *window) Maybe add spaces after gboolean to align pending with the other params? And update the copyright year. Other than those cosmetic changes the patch looks good to me.
(In reply to comment #12) > (From update of attachment 175532 [details] [review]) > > #include <libempathy/empathy-debug.h> > > > >+ > > #define CHAT_DIR_CREATE_MODE (S_IRUSR | S_IWUSR | S_IXUSR) > > That seems unnecessary Removed. > > static void > > chat_window_new_message_cb (EmpathyChat *chat, > > EmpathyMessage *message, > >+ gboolean pending, > > EmpathyChatWindow *window) > > Maybe add spaces after gboolean to align pending with the other params? I usually don't do it in files style using the old style. It doesn't buy us anything, make diff confusing (if you have to extend the spaces of all args) and is not done in the new style anway. > And update the copyright year. done.
(In reply to comment #13) > > > static void > > > chat_window_new_message_cb (EmpathyChat *chat, > > > EmpathyMessage *message, > > >+ gboolean pending, > > > EmpathyChatWindow *window) > > > > Maybe add spaces after gboolean to align pending with the other params? > > I usually don't do it in files style using the old style. It doesn't buy us > anything, make diff confusing (if you have to extend the spaces of all args) > and is not done in the new style anway. If it's not done in the new style then it's alright. BTW I've found a typo: >+ /* Pending messages have already be displayed in the approver, so we don't >+ * display a notification for those. */ s/be/been/. Feel free to fix it and push directly :)
Amended and merged to master; thanks! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
*** Bug 638921 has been marked as a duplicate of this bug. ***
*** Bug 638068 has been marked as a duplicate of this bug. ***
This issue seems to be back in empathy 2.33.2 in Natty. I can reproduce and there is also a confirmation from someone else too. should I open a a new bug report?
Yes open a new one and attach empathy-chat logs please.