GNOME Bugzilla – Bug 627769
(development version ) 2.31.91pre say all stops at links and headers in firefox and thunderbird
Last modified: 2010-09-20 10:57:43 UTC
orca version from git, version 2.31.91pre: when reading a page in firefox (version 3.511 or 3.68) say all will stop at a link. You have to press cursor up / down to read the rest of the line. On the next line you can start read all (numpad + add) until the next link / header. As i said, it does also happen in thunderbird version 3.06. With the version directly shipped from debian (orca 2.30.2-1) it does not happen, it works normal. my system: debian testing; gnome speech, espeak gnome speechdriver, but with speech-dispatcher v 0.7 tested.
I can reproduce using thunderbird 3.1.2 using the following steps: Send a message to yourself with the following content in the body. Before link. http://www.google.com After link After receive the message try read using the say all command. Orca stops in the http://www.google.com.
Created attachment 168660 [details] [review] proposed fix This solves it for me. Please test. Thanks!
*** Bug 627691 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > Created an attachment (id=168660) [details] [review] > proposed fix > > This solves it for me. Please test. Thanks! Unless I've done something wrong, do not work for me. If I go to top of this page and press a say all, orca reads only the first line. When I tried with test case from comment #1, orca reads the first line and stop.
Comment on attachment 168660 [details] [review] proposed fix Because this fixes the problem for me on a lot of other pages, not counting the case José mentioned, and because it fixes the test case Attila provided in bug 627691, I have committed this patch as the fix for that bug. Now I'll see what's up with José's test case. http://git.gnome.org/browse/orca/commit/?id=37aa48f10eaa5869cbbe28f2c6a0e8332f845ee9
ugh, that patch introduces a new problem. reversed it.
(In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=168660) [details] [review] [details] [review] > > proposed fix > > > > This solves it for me. Please test. Thanks! > > Unless I've done something wrong, do not work for me. > If I go to top of this page and press a say all, orca reads only the first > line. > When I tried with test case from comment #1, orca reads the first line and > stop. Actually, José, I do believe I have fixed the Say All bug in question. Really. Pull the latest master which has a modified version of the original patch. With master, try repeating your test, but after Orca says "Home link" do not press any keys. Wait. You may need to wait for a minute, but just be patient. Or go make a sandwich. <smile> When I do so, eventually Orca gets around to saying "New link". Again wait for a while.... This situation is really really bad, but I think it's a totally different bug. In fact, I think it might be another case of bug 599361 which you had filed. It's the very same line of content. Something about that line and how we are putting it together is problematic. Please let me know what you find. Thanks!
Created attachment 168684 [details] [review] Additional change What is in master solves the problem (not counting the wacky delay described in the previous comments with the home link on this page). But not for gnome-speech, at least not with espeak. This is an additional tweak for the Gecko SayAll code which prevents an instance of an ACSS getting sent to the speechfactories as the string to be spoken. With this change, gnome-speech sayAll works for me. (again, not counting the wacky delay for the home link on this page). Please test. Mainly for unexpected side effects. Thanks!
Comment on attachment 168684 [details] [review] Additional change Based on Lutz' feedback on the list, my testing, and the nature of this patch (don't be sending ACSS's as strings in a SayAll), I've committed this change to master. http://git.gnome.org/browse/orca/commit/?id=6c2d73f1599af0a591f20d682b2864e274b852fa
I'm going to close this out as FIXED and try to bump bug 599361 higher up on my to-do list to solve the outrageous delay with the links and entry at the top of bugzilla pages.
(In reply to comment #7) > Actually, José, I do believe I have fixed the Say All bug in question. Really. > Pull the latest master which has a modified version of the original patch. With > master, try repeating your test, but after Orca says "Home link" do not press > any keys. Wait. You may need to wait for a minute, but just be patient. Or go > make a sandwich. <smile> When I do so, eventually Orca gets around to saying > "New link". Again wait for a while.... I replaced the sandwich with a glass of wine but the result was the same as described by you. The orginal bug was fixed and there is a long delay in orca when reading the top of the page. If I were to wait for the orca to read the entire contents of the page drinking wine, I would be completely drunk in the end. Thanks.