After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627691 - When I say all a webpage content and Orca attempts to speak an image description, the say all operation is terminated
When I say all a webpage content and Orca attempts to speak an image descript...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.31.x
Other Linux
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403 404409
 
 
Reported: 2010-08-23 05:17 UTC by Hammer Attila
Modified: 2010-09-20 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This debug.out I hope show you why happening this bug. (137.20 KB, application/octet-stream)
2010-08-23 05:17 UTC, Hammer Attila
Details

Description Hammer Attila 2010-08-23 05:17:04 UTC
Created attachment 168541 [details]
This debug.out I hope show you why happening this bug.

Dear Developers,

When I would like say all a webpage content, and Orca found an image description with need spokening, the sai all operation is terminated.

How can you reproduce this issue?
1. Launch Firefox web browser, and open following website: http://www.origo.hu/hirmondo/techbazis/szamitogep/20100822-jolicloud-felhobe-vonult-a-netbookok-operacios-rendszere.html
2. Press Orca+semicolon or numpadplus key (depending your Orca keyboard layout).
3. The say all operation is terminated if Orca found an image description with need spokening, but this is not end of the document, if I would like append say all operation, I need press a down arrow key and begin again the say all operation.

I maked a debug.out file and attached with this bugreport, I think help you following information to determining why happening this problem:
I found following traceback error message with debug.out file:
Traceback (most recent call last):
  • File "/usr/local/lib/python2.6/dist-packages/orca/speechdispatcherfactory.py", line 354 in _say_all
    event_types=self._CALLBACK_TYPE_MAP.keys())
  • File "/usr/local/lib/python2.6/dist-packages/orca/speechdispatcherfactory.py", line 313 in _speak
    text = self.__addVerbalizedPunctuation(text)
  • File "/usr/local/lib/python2.6/dist-packages/orca/speechdispatcherfactory.py", line 287 in __addVerbalizedPunctuation
    newText = re.sub(ELLIPSIS, spokenEllipsis, oldText)
  • File "/usr/lib/python2.6/re.py", line 151 in sub
    return _compile(pattern, 0).sub(repl, string, count)
TypeError: expected string or buffer)

Attila
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-08-24 17:59:48 UTC

*** This bug has been marked as a duplicate of bug 627769 ***
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-08-24 18:46:53 UTC
Well, apparently the fix for this bug is not the same as the fix for the other bug -- at least not every last occurrence of it.

Therefore I've committed the proposed patch attached to the other bug as the fix for this bug. (Are we confused yet? :-)

Attila, please verify that you can no longer reproduce the problem you reported for the test case you reported using master.

Thanks!

http://git.gnome.org/browse/orca/commit/?id=37aa48f10eaa5869cbbe28f2c6a0e8332f845ee9
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-08-24 18:57:55 UTC
Reopening. I had to reverse that patch as it introduces a new problem. Trying again. For real this time. :-/
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-08-24 19:16:13 UTC
Alrighty then, I believe I have re-fixed this bug without the problem introduced by the former fix.

Attila please confirm. Thanks!

http://git.gnome.org/browse/orca/commit/?id=e6eaa9ad344bca69fd4f194c92f5c0123bbe8a28
Comment 5 Hammer Attila 2010-08-25 03:25:52 UTC
Joanie, all works fine now my machine when I this day morning updated with git master. I reopened the test webpage, and sayall the webpage content before the image description. The sayall operation now not terminated when Orca spokened the image description.
This bug is fixed now, thank you the fix!

Attila
Comment 6 Joanmarie Diggs (IRC: joanie) 2010-08-25 05:23:13 UTC
Yay! Thanks for the confirmation Attila.