GNOME Bugzilla – Bug 599361
Significant delay building up the contents of certain lines in Firefox
Last modified: 2012-02-23 19:47:47 UTC
When filling some forms in the web, I am experiencing delays when I press the tab key to advance to the next field in the form. To reproduce you can try the following steps: 1. Go to https://bugzilla.gnome.org/ 2. Press the tab key until you find an edit field. It is located before a button labeled find. 3. Type something in the field and press the tab key. After press the tab key orca takes about five seconds to announce the find button. The same happens if I press shift+tab. I am runnint orca 2.29-1pre. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5pre) Gecko/20091021 Ubuntu/9.04 (jaunty) Shiretoko/3.5.5pre
Confirmed and it looks like the problem has to with Orca recalculating text for a line that has lots of links on it. :-(
Temporarily flagging this as "3.0!" -- at least for triage. To be honest, my guess is that there's not going to be anything we can do for 3.0. But I want to dig deeper before saying that for sure.
The winner seems to be updateBraille(), which is not all that surprising. Still investigating.
I deep dove into this. I'm redoing updateBraille(). Stay tuned as it's a work in progress, but I expect to see improved performance once I'm through.
This seems to be pretty fast for me with current orca, what is the state of the world with braille?
Thanks for the reminder/prompt. I have some code in progress (but set aside) which cleaned up the Gecko braille code and sped up things. I need to resume this work. Noting it down on my to-do list.
(In reply to comment #5) > This seems to be pretty fast for me with current orca, what is the state of the > world with braille? Hi Trev. I am experiencing some delays when I try file a bug in bugzilla. The problem happens when I am in the form to choose component, version and etc. It seems to me that the problem happens when I access the form for the first time. If I back to the previous page and reload the form, there are no delays. Perhaps a wrong version of firefox?
(In reply to comment #7) > (In reply to comment #5) > > This seems to be pretty fast for me with current orca, what is the state of the > > world with braille? > > Hi Trev. I am experiencing some delays when I try file a bug in bugzilla. > The problem happens when I am in the form to choose component, version and etc. > It seems to me that the problem happens when I access the form for the first > time. If I back to the previous page and reload the form, there are no delays. > Perhaps a wrong version of firefox? Are you using braille? if so I'd suspect braille per comment 6. If not then maybe its a firefox issue, I'm using today's nightly and it seems fine.
(In reply to comment #8) > > Are you using braille? if so I'd suspect braille per comment 6. If not then > maybe its a firefox issue, I'm using today's nightly and it seems fine. No, I do not use braile. Can you give me a link to download the today's nightly? I am running in a 64-bit ubuntu 10.10.
(In reply to comment #9) > (In reply to comment #8) > > > > Are you using braille? if so I'd suspect braille per comment 6. If not then > > maybe its a firefox issue, I'm using today's nightly and it seems fine. > > No, I do not use braile. > Can you give me a link to download the today's nightly? > I am running in a 64-bit ubuntu 10.10. As a reminder, I'm afraid we are all using braille -- whether you happen to have a display or not. This will continue to be the case until we further separate out that code which I think will be done in time for the 3.0 release.
(In reply to comment #10) > As a reminder, I'm afraid we are all using braille -- whether you happen to > have a display or not. This will continue to be the case until we further > separate out that code which I think will be done in time for the 3.0 release. Just out of curiosity, even if the option to support braille is disabled in the preferences page? Thanks.
(In reply to comment #11) > Just out of curiosity, even if the option to support braille is disabled in the > preferences page? I'm afraid so. A while back I tried to just stop braille from happening in that circumstance, but we still wound up doing lots of the braille work -- and it introduced new bugs. :-( The different presentation modalities are going to be separated out. Again, hopefully in time for 3.0. Until that occurs, like I said, we are all using braille, whether you are using braille in actuality or not.
Created attachment 194678 [details] [review] Fix the problem of speech delay in entry fields When the object selected is a edit field (pyatspi.ROLE_ENTRY), we have a problem with the offset in the function findObjectOnLine (Gecko's script). The offset is -1 when the object is a edit field. If you apply the patch, when you press shift+tab, orca don't experience delays in speech. I've attached another file containing output tests running orca with and without applied patch.
Created attachment 194681 [details] Output test This is the file contains output tests running orca with and without applied patch. I've only attached some lines of the output files.
(In reply to comment #13) > Created an attachment (id=194678) [details] [review] > Fix the problem of speech delay in entry fields > > When the object selected is a edit field (pyatspi.ROLE_ENTRY), we have a > problem with the offset in the function findObjectOnLine (Gecko's script). > > The offset is -1 when the object is a edit field. > > If you apply the patch, when you press shift+tab, orca don't experience delays > in speech. > After apply the patch I am experiencing some delay if I type quickly in the edit field and press the tab key. After press the tab key I hear part of the chars typed before orca announce the next field. One place where this happens is the login field of bugzilla. I don't know if this matter, but I am running firefox 6.
(In reply to comment #15) > After apply the patch I am experiencing some delay if I type quickly in the > edit field and press the tab key. > After press the tab key I hear part of the chars typed before orca announce the > next field. > One place where this happens is the login field of bugzilla. > I don't know if this matter, but I am running firefox 6. I seen this problem, but if you don't use the patch, when you type some text and press tab key, the problem is the same. I am running firefox 6 too.
Comment on attachment 194678 [details] [review] Fix the problem of speech delay in entry fields master: http://git.gnome.org/browse/orca/commit/?id=88dcc414946810b3987e6b4003e28aae4ef42744 orca-xdesktop: http://git.gnome.org/browse/orca/commit/?h=orca-xdesktop&id=7664bf5ee8501c4afe31438d6395941dd4d2eeff
Victor, I'm assigning this to you. Gecko's updateBraille() method is all kinds of inefficient. In addition, there is the issue (not caused by your patch) raised by José. Personally, I prefer to open a new bug per issue rather than allow bugs to become uber-bugs. But it's up to you. Thanks!
When I update the orca's master 3.1.92pre, the problem reported by José seems to be fixed. Could you check the problem? I can't reproduce this bug in the new Orca version. I am using Firefox 6.0.2.
Created attachment 197236 [details] debug output files I have checked the reported problem by José and since I updated of 3_1_90 to 3_1_92, I can't reproduce this problem. I have checked this problem with the orca's version 3_0_0, 3_1_5, 3_1_92 and orca-xdesktop. I'm attach two debug files, two master version (master and master-xdesktop). I have checked the master version with jhbuild and gnome-shell in ubuntu natty (11.04). I have checked the master-xdesktop version with natty. I am running Firefox 6.0.2.
I forgot it, the master version in this moment is 3.2.0.pre
I can not reproduce the problems reported in this bug using ubuntu 11.10, firefox 10.2 and orca built from master. Time to close this one?
Yeah, I think so. Thanks!