After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610978 - Embedded Terminal - CTRL+F9 keybinding doesn't close bottom panel
Embedded Terminal - CTRL+F9 keybinding doesn't close bottom panel
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 618841 649120 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-24 17:21 UTC by pablolm2005
Modified: 2019-03-23 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 610978 - Allow using normal keyboard shortcuts in terminal plugin (1.17 KB, patch)
2013-06-29 22:28 UTC, Garrett Regier
committed Details | Review

Description pablolm2005 2010-02-24 17:21:15 UTC
CTRL+F9 keybinding doesn't close bottom panel, it will instead print garbage on the embedded terminal
Comment 1 Garrett Regier 2010-05-17 07:36:03 UTC
*** Bug 618841 has been marked as a duplicate of this bug. ***
Comment 2 jessevdk@gmail.com 2010-05-17 08:18:17 UTC
To put some light on the issue, the terminal emulator consumes almost all key events. To solve this, we need to handle Ctrl+F9 manually in the key event of the terminal widget. This means looking up, and keeping track of, the accelerator of the Show/Hide panel action using the accelmap, and comparing the key/mod with that. Then we need to activate that binding in the accelmap manually and block the terminal widget from trying to handle it.

At least, that's what I think we need to do.
Comment 3 Rakesh Pandit 2010-05-28 08:38:49 UTC
Hi,

Is there any update on this one ?

--
Regards,
Rakesh Pandit
Comment 4 Carnë Draug 2011-05-18 02:58:09 UTC
*** Bug 649120 has been marked as a duplicate of this bug. ***
Comment 5 Carnë Draug 2011-05-18 03:01:30 UTC
I was told that this bug may be on vte. I have reported it some time ago there at bug #649120 but I'm now marking it as duplicate of this one.

I'd also extend it to the fact that the terminal intercepts other gedit keybindings such as F6.

Someone who knows better should move it to the appropriate project.
Comment 6 Adam Dingle 2013-05-24 11:36:44 UTC
See also bug 700899 (provide shortcut to switch back to main editing view), which is related.
Comment 7 Garrett Regier 2013-06-29 22:28:23 UTC
Created attachment 248072 [details] [review]
Bug 610978 - Allow using normal keyboard shortcuts in terminal plugin

Now the key-press-event handler does:
  - Special shortcuts: Ctrl+Tab, Ctrl+Shift+Tab, Ctrl+Shift+C, Ctrl+Shift+V
  - Allows Vte.Terminal to handle specific shortcuts (found them online)
  - Attempts to activate a global gedit shortcut and if that fails allows Vte.Terminal to handle the key-press-event


I don't know if the specifically allowed shortcuts are all correct.
Comment 8 Garrett Regier 2013-06-29 22:49:22 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 9 Garrett Regier 2013-06-29 22:49:54 UTC
Comment on attachment 248072 [details] [review]
Bug 610978 - Allow using normal keyboard shortcuts in terminal plugin

Added comment about why we special case some Vte.Terminal shortcuts.