After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600688 - Migrate from libglade to GtkBuilder
Migrate from libglade to GtkBuilder
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other All
: High blocker
: 0.14.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on: 650381
Blocks: 335805 572883 632113
 
 
Reported: 2009-11-04 14:42 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-06-06 06:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkBuilder migration patch (285.12 KB, patch)
2010-02-14 20:56 UTC, Simon Wenner
none Details | Review
GtkBuilder migration patch (286.36 KB, patch)
2010-02-14 21:24 UTC, Simon Wenner
none Details | Review
updated patch (286.54 KB, patch)
2010-02-14 21:52 UTC, Simon Wenner
none Details | Review

Description Javier Jardón (IRC: jjardon) 2009-11-04 14:42:26 UTC
In GNOME 2.27, libglade has been deprecated in favor of GtkBuilder (and will completely remove for GNOME 3 (2010)).
See http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkBuilder.html for
migration instructions.
Also see http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder.

See http://www.gnome.org/~fpeters/299.html for automated statistics.
Comment 1 Brandon Lewis 2009-12-16 21:51:27 UTC
I'd actually support removing XML entirely.
Comment 2 Edward Hervey 2009-12-18 07:53:54 UTC
GtkBuilder is also XML based. There's not much we can do about this (apart from hand-coding all those widgets/windows/dialogboxes) :(

We should switch to GtkBuilder ASAP though.
Comment 3 Stephen Griffiths 2010-02-06 03:23:26 UTC
removed from make pitivi work on non-GNOME systems tracker, this is about removing deprecated libraries.
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-06 03:28:32 UTC
Indeed, if you remove deprecated libraries and use only GTK+, your code is more portable (If not, you need libglade in all the other platforms)
Comment 5 Stephen Griffiths 2010-02-06 03:50:58 UTC
true :)
Comment 6 Simon Wenner 2010-02-14 16:59:50 UTC
I'm working on this bug. Stay tuned!
Comment 7 Simon Wenner 2010-02-14 20:56:10 UTC
Created attachment 153799 [details] [review]
GtkBuilder migration patch
Comment 8 Simon Wenner 2010-02-14 20:57:15 UTC
Done.

I removed ui/glade.py and created a new file ui/builder.py that provides the same functionality based on GtkBuilder.

I following interface files are not tested, but should work:
pitivi/ui/cam_capture.ui (My webcam was not detected)
pitivi/ui/net_capture.ui (Where can I enable that?)
pitivi/ui/screencast_manager.ui (Buggy)

All other interface parts were tested and should work as before.
Comment 9 Simon Wenner 2010-02-14 21:24:09 UTC
Created attachment 153801 [details] [review]
GtkBuilder migration patch

I missed POTFILES.in
Comment 10 Javier Jardón (IRC: jjardon) 2010-02-14 21:44:30 UTC
Hello Simon,

Thank you for working on this
You should add

[type: gettext/glade]

before each .ui in POTFILES.in

See http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder
Comment 11 Simon Wenner 2010-02-14 21:52:46 UTC
Created attachment 153802 [details] [review]
updated patch

Added [type: gettext/glade] before each .ui in POTFILES.in
Comment 12 André Klapper 2010-04-15 15:30:17 UTC
Maintainers: ping - can this patch get a review/commit?
Comment 13 Brandon Lewis 2010-04-15 16:15:40 UTC
Just wanted to let you know that I see your patch, and merging it is on my "TODO" list.

I really should apply this soon. The issue is that I was working on some changes to a few of the glade-based dialogs, and was hoping to complete those before merging this patch. That branch turned into a bit of a "powerplant", so I'm thinking I should try to merge first. Meanwhile I'll try and cut the other branch down to size.
Comment 14 Javier Jardón (IRC: jjardon) 2010-09-23 11:59:41 UTC
Maintainers: ping2 ;) - can this patch get a review/commit?
Comment 15 Jean-François Fortin Tam 2010-12-19 04:37:51 UTC
This needs to be re-reviewed now that emdash's big UI changes have landed... I would doubt that the patch still applies cleanly.

Interestingly enough, I also stumbled upon https://github.com/stephh/PiTiVi/commits/gtkbuilder today, which was not mentionned in this bug report...
Comment 16 Sebastian Dröge (slomo) 2011-05-25 18:54:55 UTC
Any progress on this?
Comment 17 Jean-François Fortin Tam 2011-05-25 22:01:29 UTC
stephh is currently working on this in the branch mentionned in comment 15 (he was previously blocked by the massive UI changes that landed a few months ago).

This depends on some other branch being merged first (bug #650381). This is also a blocker for eventually migrating to PyGI and GTK3 (bug #632113).

This summer, we fix this, once and for all.
Comment 18 Thibault Saunier 2011-06-06 06:38:08 UTC
commit d6ce97800c306d052a6acaff1ae43935292efb84
Author: Thibault Saunier <thibault.saunier@collabora.com>
Date:   Fri Jun 3 02:13:10 2011 -0400

    Port PiTiVi to GtkBuilder!