After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650381 - Move resources files to a data/ directory
Move resources files to a data/ directory
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal normal
: 0.14.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 600688
 
 
Reported: 2011-05-17 08:55 UTC by Stéphane Maniaci
Modified: 2011-06-07 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stéphane Maniaci 2011-05-17 08:55:48 UTC
icons, pixmaps and UI files should be moved to a data/ directory in order to separate resources files from source code.

I have a working branch over there: https://github.com/stephh/PiTiVi/tree/datadir, please check it out, merge and report any things I might have forget.

Here's a little summary of the changes, I would be glad to hear your feedback about it:
- /pitivi/pixmaps -> /data/pixmaps
- /pitivi/ui/*.xml|glade -> /data/ui/*.ui
- /icons -> /data/icons
- pixmaps and UI files are now installed in /usr/share/pitivi, all together, like most programs (I think)
- configure.py.in gets a get_data_dir() and get_ui_dir() method ;
- get_global_pixmap_dir() is gone, not used in the code (except some win32 duplicate file, grep for it in master)
- All UI file now use get_ui_dir() properly, so does glade.py. I deleted some win32 .exe check, because a) easier to deal with, b) this should be done in configure.py.in anyway, right?

This is all I can think of right now, make sure to look at the branch and the git log/diff. Thanks!
Comment 1 Jean-François Fortin Tam 2011-06-07 00:13:12 UTC
commit 0e397fadf8c206c716f3b31cd1145149d5b53f05
Author: Stéphane Maniaci <stephane.maniaci@gmail.com>
Date:   Fri May 13 17:34:35 2011 -0700

    Move our pixmaps and icons into a data/ dir.    
    And adapt/simplify configure.py.in appropriately

commit c40a5aa22d90bf6b608798cd29f1dcd8a660a627
Author: Stéphane Maniaci <stephane.maniaci@gmail.com>
Date:   Mon May 16 19:01:42 2011 -0700

    Move UI files to the data/ui directory.