GNOME Bugzilla – Bug 600504
Storing podcast base names can overwrite files from the same podcast
Last modified: 2018-05-24 14:48:47 UTC
Currently podcast files are stored in $XDG_MUSIC_DIR/$podcast_title/$filename where $filename is the filename on the URL for that track. This is not safe as $filename can be the same for multiple tracks in a given podcast, e.g. The podcast: http://deimos3.apple.com/WebObjects/Core.woa/Feed/cmu.edu.1335575211.01335575214 Has tracks: http://deimos3.apple.com/WebObjects/Core.woa/FeedEnclosure/cmu.edu.1335575211.01335575214.1380083777/enclosure.mp3 http://deimos3.apple.com/WebObjects/Core.woa/FeedEnclosure/cmu.edu.1335575211.01335575214.1379722751/enclosure.mp3 Which will both be written as "enclosure.mp3" Playing either of those tracks in Rhythmbox will play the last downloaded one. From Ubuntu: https://bugs.edge.launchpad.net/ubuntu/+source/rhythmbox/+bug/445141
Looks like a good number of podcasts are broken in Rhythmbox because of this. Worse yet, there is no error message to show that this isn't working! I can try to download many files in one of the podcasts reported here: https://bugs.edge.launchpad.net/ubuntu/+source/rhythmbox/+bug/445141 They appear to download fine, but after transferring to a portable player you'll see that there is only ONE of the many episodes that were supposed to be downloaded... and trying to play them on the computer gives the wrong episode for all but one file. I really like Rhythmbox, I'd like to use it for all audio podcasts, but this bug breaks several podcasts I would like to subscribe to :(
Created attachment 164278 [details] [review] Use escaped URI instead of basename for downloaded podcasts
*** Bug 623340 has been marked as a duplicate of this bug. ***
Bug 551298 and bug 625741 in the gvfs http backend are making this much more of a problem than it should be.
*** Bug 626880 has been marked as a duplicate of this bug. ***
Bug 626880 was caused by this patch. The resulting filename was too long, so the download failed.
*** Bug 631818 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/828.