After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625741 - only provides edit name if display name is also requested
only provides edit name if display name is also requested
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: http backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-01 04:06 UTC by Jonathan Matthew
Modified: 2012-12-06 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.42 KB, patch)
2010-08-01 04:18 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2010-08-01 04:06:25 UTC 
The HTTP backend only provides standard::edit-name if standard::display-name is also requested.
Comment 1 Jonathan Matthew 2010-08-01 04:18:58 UTC 
Created attachment 166908 [details] [review]
fix

gvfs_file_info_populate_names_as_local sets both display-name and edit-name, so we don't need the subsequent call to g_file_info_set_edit_name, we just need to call populate_names_as_local when either one is requested.
Comment 2 Tomas Bzatek 2012-12-06 11:18:12 UTC 
Makes sense, this seems to be safer way for setting name attributes. Pushed to master:

commit db9d1795582ad888b1653f5b43718bbe263ff369
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Thu Dec 6 12:16:40 2012 +0100

    http: Provide edit-name whether display-name is also requested or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=625741
    
    Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>