GNOME Bugzilla – Bug 586888
Remove "Info" from contact's context menu, replace "Edit" with stock "Properties"
Last modified: 2012-02-09 13:29:37 UTC
Rationale: "Info" shows the same thing the tooltip does. This happens to be identical to the upper part of the contact editor. Therefore "Edit" is a superset of "Info". Now for the name, "Edit" does not actually let you edit all of the information as some of it is read-only (account name, status message) so the name is quite misleading. It's similar to the file properties window in Nautilus and I think we could use the same stock menu entry in Empathy for consistency.
Created attachment 140226 [details] [review] Proposed patch What the patch does is as follows: * "Edit" menu entry is renamed to "Properties". * "Edit Contact Information" window is renamed to "<Contact Name> Properties". * If editing is enabled it always adds the "Edit" menu entry. * The "Edit" window determines if contact is actually editable or not and degrades itself accordingly. * If editing is enabled, "Information" menu entry is skipped. * No functions were renamed and no gnomes harmed during testing of this patch. Most of it was done in order to remain API-compatible with previous versions.
For the record: We are currently in the UI and string change announcement period. If we manage to land this before the Tuesday UI freeze, remember to contact the appropriate teams.
Can we get this is now that 2.29 is in development?
I'm not sure, "properties" on a contact seems weird to me. What the others think?
As suggested on IRC maybe we should merge the "Info" and "Edit" menu/dialog. Adding Nick and Matthew in CC for their usuability pov on this question.
(In reply to comment #5) > As suggested on IRC maybe we should merge the "Info" and "Edit" menu/dialog. As I mentioned that... I think the user's visible alias should be an editable label (as used in gnome-about-me for example). Otherwise all the information in the "Info" dialogue is already available in the "Edit Information" dialogue. And "Properties" on a human contact is probably pretty poor form.
Any chance for resolving this one in time for 2.30?
Indeed, Edit already shows all the information in "Information". I like the idea of merging both entries/dialogs.
Works for me.
Actually we are in the process of killing these dialogs; see bug #669747 and bug #669559.