After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669559 - Rely on gnome-contacts for the information dialog
Rely on gnome-contacts for the information dialog
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 669482
 
 
Reported: 2012-02-07 11:15 UTC by Guillaume Desmottes
Modified: 2012-02-07 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gnome-contacts instead of the information dialog (3.02 KB, patch)
2012-02-07 12:50 UTC, Guillaume Desmottes 		committed Details | Review
remove empathy-individual-information-dialog (14.97 KB, patch)
2012-02-07 12:50 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-02-07 11:15:49 UTC 
The contact information dialog isn't really useful any more. It displays a subset of the information presented in gnome-contact in a crappy way.
The only extra info it got is the location which is very uncommon and displayed in the contact tooltip anyway.

Let's just get rid of it and use gnome-contacts directly.
Comment 1 Guillaume Desmottes 2012-02-07 12:50:11 UTC 
Created attachment 206979 [details] [review]
Use gnome-contacts instead of the information dialog
Comment 2 Guillaume Desmottes 2012-02-07 12:50:15 UTC 
Created attachment 206980 [details] [review]
remove empathy-individual-information-dialog
Comment 3 Xavier Claessens 2012-02-07 13:18:07 UTC 
I think you should factor out most of the function to start gnome-contact, will be useful in other places I guess. Otoh it can wait for when you'll need it :)

+1 anyway
Comment 4 Guillaume Desmottes 2012-02-07 15:18:37 UTC 
Yeah I prefer to do it later, I think we should consider merging menu items before starting to call gnome-contact from other places.
Comment 5 Guillaume Desmottes 2012-02-07 15:20:16 UTC 
Attachment 206979 [details] pushed as 13940bc - Use gnome-contacts instead of the information dialog
Attachment 206980 [details] pushed as 8c56829 - remove empathy-individual-information-dialog